Revert "do not merge: always force parquet format in cdc tests" #103928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible" This reverts commit 63eccd4. Release note: None Epic: None
|
This change is |
jayshrivastava
changed the title
13 tasks
HonoreDB
approved these changes
May 26, 2023
jayshrivastava
force-pushed
the
revert-parquet
branch
2 times, most recently
from
1b6c82d
to
4f1b514
Compare
Previously, some tests would fail due to invalid conversion from parquet to JSON in testing. These failures showed two underlying issues with how columns were written: - in tests watching a column family not containing the primary key of the table, we would not write the primary key to the parquet file - in tests where the primary key was defined with a particular order which is different than the table, the parquet testing code would not order the keys correctly This change fixes the two above issues by (a) using the correct iterators on `cdcevent.Row` and writing more verbose metadata to the parquet file to use in testing. Epic: None Release note: None
jayshrivastava
force-pushed
the
revert-parquet
branch
2 times, most recently
from
df3f06b
to
875cbfa
Compare
|
bors r=HonoreDB |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "do not merge: always force parquet format in cdc tests" #103928
This reverts commit 63eccd4.
Release note: None
Epic: None
changefeedccl: refactor parquet column iterators
Previously, some tests would fail due to invalid conversion
from parquet to JSON in testing. These failures showed two
underlying issues with how columns were written:
key of the table, we would not write the primary key to
the parquet file
order which is different than the table, the parquet testing
code would not order the keys correctly
This change fixes the two above issues by (a) using the correct
iterators on
cdcevent.Rowand writing more verbosemetadata to the parquet file to use in testing.
Epic: None
Release note: None