kv,server: extract Cluster service and register with DRPC server
#148451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
This is a follow-up to cockroachdb#145195, where we extracted `KVBatch` from the `Internal` service. Here, we do the same with `Cluster`. The TL;DR is that smaller services are easier to maintain and can be more smoothly migrated to DRPC. We also enable this service on the DRPC server. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
This change replaces the direct client creation through `NewInternalClient` with the gRPC adapter. See cockroachdb#147950 for more context. Also, since we have a more targeted service for `Join` RPC, we should use its adapter interface. Release note: none Epic: CRDB-48923
shubhamdhama
force-pushed
the
register-svc-cluster
branch
from
900a685 to
b884f97
Compare
Contributor
Author
|
bors r=cthumuluru-crdb |
Contributor
|
Build succeeded: |
celeste-cockroachdb
bot
added
v25.3.0-prerelease
and removed
target-release-25.3.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kv,server: extract `Cluster` service and register with DRPC serverThis is a follow-up to #145195, where we extracted
KVBatchfrom theInternalservice. Here, we do the same withCluster. The TL;DRis that smaller services are easier to maintain and can be more smoothly
migrated to DRPC.
We also enable this service on the DRPC server. This is controlled by
rpc.experimental_drpc.enabled(off by default).This change is part of a series and is similar to: #146926
Note: This only registers the service; the client is not updated to use the
DRPC client, so this service will not have any functional effect.
server: replace `RPCClusterClient` for cluster join operationThis change replaces the direct client creation through
NewInternalClientwith the gRPC adapter. See #147950 for more context. Also, since we have a
more targeted service for
JoinRPC, we should use its adapter interface.Release note: none
Epic: CRDB-48923