Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed monitor sample to prepone region of correct clock edge #28

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Changed monitor sample to prepone region of correct clock edge #28

merged 1 commit into from
Oct 20, 2021

Conversation

gtaylormb
Copy link
Contributor

No description provided.

@gtaylormb
Copy link
Contributor Author

As discussed in #26

@ktbarrett
Copy link
Member

This is an interface-breaking change, not sure what our policy for this repo is... @cocotb/maintainers any opinions?

@imphil
Copy link
Member

imphil commented Oct 20, 2021

This is an interface-breaking change, not sure what our policy for this repo is... @cocotb/maintainers any opinions?

This repo is in the 0.x version range, during which we can do whatever we want basically according to semver. Let's make use of this freedom.

@ktbarrett
Copy link
Member

The ReadOnly import should be removed.

@imphil
Copy link
Member

imphil commented Oct 20, 2021

The ReadOnly import should be removed.

@gtaylormb I made this change to your PR, and will merge as soon as CI has completed.

@imphil imphil merged commit 905935b into cocotb:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktbarrett ktbarrett ktbarrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtaylormb @ktbarrett @imphil