-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace UploadErrorEnum with shared.upload.constants.UploadErrorCode #820
Conversation
This PR includes changes to |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
===========================================
Coverage 96.23000 96.23000
===========================================
Files 812 812
Lines 18550 18548 -2
===========================================
- Hits 17851 17849 -2
Misses 699 699
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though we should have another look at breaking changes in the graphql api.
as title
i fixed some plumbing around error handling in upload processing. everything that used to be "unknown" will still be "unknown" for now but now there's a catchall for any exceptions we have not already assigned an error code. we can watch logs for exceptions we have not already made an error code for