Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace UploadErrorEnum with shared.upload.constants.UploadErrorCode #820

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Sep 12, 2024

as title

i fixed some plumbing around error handling in upload processing. everything that used to be "unknown" will still be "unknown" for now but now there's a catchall for any exceptions we have not already assigned an error code. we can watch logs for exceptions we have not already made an error code for

@matt-codecov matt-codecov requested review from a team as code owners September 12, 2024 19:50
Copy link
Contributor

This PR includes changes to shared. Please review them here: codecov/shared@d4ceb0e...d26f241

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (e72e553) to head (a3d1650).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #820   +/-   ##
===========================================
  Coverage   96.23000   96.23000           
===========================================
  Files           812        812           
  Lines         18550      18548    -2     
===========================================
- Hits          17851      17849    -2     
  Misses          699        699           
Flag Coverage Δ
unit 92.45% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 92.45% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though we should have another look at breaking changes in the graphql api.

graphql_api/types/upload/upload.graphql Outdated Show resolved Hide resolved
@matt-codecov matt-codecov added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 52b7d30 Sep 16, 2024
19 checks passed
@matt-codecov matt-codecov deleted the pr820 branch September 16, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants