add new UploadErrorEnum values #3193
Conversation
Bundle ReportChanges will increase total bundle size by 432 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 432 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3193 +/- ##
===========================================
Coverage 98.13000 98.13000
===========================================
Files 935 935
Lines 14510 14510
Branches 3968 3968
===========================================
Hits 14240 14240
Misses 265 265
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3193 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 935 935
Lines 14510 14510
Branches 3973 3886 -87
=======================================
Hits 14240 14240
Misses 265 265
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3193 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 935 935
Lines 14510 14510
Branches 3968 3886 -82
=======================================
Hits 14240 14240
Misses 265 265
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3193 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 935 935
Lines 14510 14510
Branches 3886 3968 +82
=======================================
Hits 14240 14240
Misses 265 265
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
as title
https://github.com/codecov/gazebo/tree/main/src/pages/CommitDetailPage/CommitCoverage/UploadsCard/RenderError.tsx appears to be where we would reference these codes to decide what to display in the UI. i am not going to touch that, but i'll let folks know when i add new codes so appropriate text can be worked out
i fixed some plumbing around error handling in upload processing. everything that used to be "unknown" will still be "unknown" for now but now there's a catchall for any exceptions we have not already assigned an error code. we can watch logs for exceptions we have not already made an error code for