-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add catchall exception handling to build_report_from_raw_content() #703
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #703 +/- ##
==========================================
- Coverage 98.08% 98.06% -0.02%
==========================================
Files 434 434
Lines 36746 36751 +5
==========================================
Hits 36041 36041
- Misses 705 710 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #703 +/- ##
==========================================
- Coverage 98.08% 98.06% -0.02%
==========================================
Files 434 434
Lines 36746 36751 +5
==========================================
Hits 36041 36041
- Misses 705 710 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #703 +/- ##
==========================================
- Coverage 98.08% 98.06% -0.02%
==========================================
Files 434 434
Lines 36746 36751 +5
==========================================
Hits 36041 36041
- Misses 705 710 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
==========================================
- Coverage 98.12% 98.11% -0.02%
==========================================
Files 475 475
Lines 38101 38106 +5
==========================================
Hits 37388 37388
- Misses 713 718 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes sense, and I think you can also clean up some error handling in the caller function as well, as that has some try/except logic as well.
1bb5224
to
f1611b1
Compare
i've changed this a little but there is something to call out. previously, uncaught exceptions would get rewritten in human-readable form and caught exceptions would be deleted in accordance with |
This PR includes changes to |
using the shared enum now |
This PR includes changes to |
codecov/engineering-team#1520 (or starts to, anyway)
after this deploys we should watch GCP logs to see what types of unrecognized exceptions are thrown and add catch cases for them + new error codes. then we can display UIs more consistently/descriptively in the UI.