Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add catchall exception handling to build_report_from_raw_content() #703

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Sep 11, 2024

codecov/engineering-team#1520 (or starts to, anyway)

after this deploys we should watch GCP logs to see what types of unrecognized exceptions are thrown and add catch cases for them + new error codes. then we can display UIs more consistently/descriptively in the UI.

@matt-codecov matt-codecov requested review from Swatinem and a team and removed request for Swatinem September 11, 2024 16:52
@codecov-staging
Copy link

codecov-staging bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
services/report/__init__.py 77.77% 4 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   98.08%   98.06%   -0.02%     
==========================================
  Files         434      434              
  Lines       36746    36751       +5     
==========================================
  Hits        36041    36041              
- Misses        705      710       +5     
Flag Coverage Δ
integration 98.06% <89.47%> (-0.02%) ⬇️
latest-uploader-overall 98.06% <89.47%> (-0.02%) ⬇️
unit 98.06% <89.47%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <80.95%> (-0.04%) ⬇️
OutsideTasks 98.08% <77.77%> (-0.02%) ⬇️
Files Coverage Δ
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
tasks/upload_processor.py 99.42% <100.00%> (-0.03%) ⬇️
services/report/__init__.py 96.17% <77.77%> (-0.98%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (27fd7a5) to head (82470bf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/report/__init__.py 77.77% 4 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   98.08%   98.06%   -0.02%     
==========================================
  Files         434      434              
  Lines       36746    36751       +5     
==========================================
  Hits        36041    36041              
- Misses        705      710       +5     
Flag Coverage Δ
integration 98.06% <89.47%> (-0.02%) ⬇️
latest-uploader-overall 98.06% <89.47%> (-0.02%) ⬇️
unit 98.06% <89.47%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <80.95%> (-0.04%) ⬇️
OutsideTasks 98.08% <77.77%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
tasks/upload_processor.py 99.42% <100.00%> (-0.03%) ⬇️
services/report/__init__.py 96.17% <77.77%> (-0.98%) ⬇️

Copy link

codecov-public-qa bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (27fd7a5) to head (82470bf).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   98.08%   98.06%   -0.02%     
==========================================
  Files         434      434              
  Lines       36746    36751       +5     
==========================================
  Hits        36041    36041              
- Misses        705      710       +5     
Flag Coverage Δ
integration 98.06% <89.47%> (-0.02%) ⬇️
latest-uploader-overall 98.06% <89.47%> (-0.02%) ⬇️
unit 98.06% <89.47%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <80.95%> (-0.04%) ⬇️
OutsideTasks 98.08% <77.77%> (-0.02%) ⬇️
Files Coverage Δ
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
tasks/upload_processor.py 99.42% <100.00%> (-0.03%) ⬇️
services/report/__init__.py 96.17% <77.77%> (-0.98%) ⬇️

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.11%. Comparing base (27fd7a5) to head (82470bf).
Report is 1 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/report/__init__.py Critical 77.77% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   98.12%   98.11%   -0.02%     
==========================================
  Files         475      475              
  Lines       38101    38106       +5     
==========================================
  Hits        37388    37388              
- Misses        713      718       +5     
Flag Coverage Δ
integration 98.06% <89.47%> (-0.02%) ⬇️
latest-uploader-overall 98.06% <89.47%> (-0.02%) ⬇️
unit 98.06% <89.47%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.06% <80.95%> (-0.04%) ⬇️
OutsideTasks 98.08% <77.77%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
tasks/upload_processor.py 99.42% <100.00%> (-0.03%) ⬇️
services/report/__init__.py Critical 96.39% <77.77%> (-0.98%) ⬇️
Related Entrypoints
run/app.tasks.upload.UploadProcessor

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, and I think you can also clean up some error handling in the caller function as well, as that has some try/except logic as well.

@matt-codecov
Copy link
Contributor Author

this makes sense, and I think you can also clean up some error handling in the caller function as well, as that has some try/except logic as well

i've changed this a little but there is something to call out. previously, uncaught exceptions would get rewritten in human-readable form and caught exceptions would be deleted in accordance with should_delete_archive(). now, any error is rewritten in human-readable form and not deleted.

Copy link

This PR includes changes to shared. Please review them here: codecov/shared@42f83ec...d26f241

@matt-codecov
Copy link
Contributor Author

using the shared enum now

Copy link

This PR includes changes to shared. Please review them here: codecov/shared@5cc5f48...d26f241

@matt-codecov matt-codecov added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 4ec7500 Sep 16, 2024
14 of 27 checks passed
@matt-codecov matt-codecov deleted the pr703 branch September 16, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants