Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulator: Remove comma pedal sensor #32030

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

mimi89999
Copy link
Contributor

Since comma pedal was removed in fa12a67 it makes no sense to simulate its output.

Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions github-actions bot added simulation running openpilot in environments like CARLA tools labels Mar 27, 2024
@adeebshihadeh adeebshihadeh merged commit 1637265 into commaai:master Mar 27, 2024
27 checks passed
@mimi89999 mimi89999 deleted the sim_pedal branch March 27, 2024 16:48
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request May 14, 2024
nworb-cire pushed a commit to opgm/openpilot that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simulation running openpilot in environments like CARLA tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants