Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/simulator: Add metadrive simulation to GHA #32513

Closed
wants to merge 26 commits into from

Conversation

bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented May 22, 2024

Resolves #30693

Copy link
Contributor

github-actions bot commented May 22, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@bongbui321 bongbui321 marked this pull request as draft May 22, 2024 20:05
@bongbui321 bongbui321 changed the title CI: Add metadrive simulation to GH CI: Add metadrive simulation to GHA May 22, 2024
@bongbui321 bongbui321 changed the title CI: Add metadrive simulation to GHA CI/simulator: Add metadrive simulation to GHA May 24, 2024
@bongbui321 bongbui321 force-pushed the metadrive_gha branch 2 times, most recently from 98111b6 to 83b638e Compare May 28, 2024 20:16
@bongbui321
Copy link
Contributor Author

bongbui321 commented Jun 2, 2024

Will need to do more investigation in how to make CI run in real time on the GIthub Runner.
They only have 4 processes with no 3D rendering GPU acceleration. The Virtual GPUs provided by GH don't have the renderD128 files.
image

The image above is from not being able to use gpu forglsl (Metadrive uses this to draw and color terrain - road, lane-line). Probably need mesa to fall back to 3D rendering on CPU, but then it would load more onto the 4 Processes that is already struggling to run all OP processes and MetaDrive

@bongbui321
Copy link
Contributor Author

@adeebshihadeh Not sure if this is bounty can be solved at this time, maybe extended lock? The problem is that the free github runners don't have 3d rendering capability (explained in the comment above), resulting in slower frame render and no color. I see that github runners might have gpu (probably a while until then, and it seems that they would only offer that to Team and Enterprise cloud plans)
https://github.blog/changelog/2023-10-31-run-your-ml-workloads-on-github-actions-with-gpu-runners/
https://www.reddit.com/r/github/comments/1bnu5zc/accelerate_your_cicd_with_arm_gpu_runners_in/

Copy link
Contributor

This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity.

@github-actions github-actions bot added the stale label Jun 29, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run MetaDrive simulation test in GitHub Actions
1 participant