Simulator: update MetaDrive to latest #32576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
| @@ -140,7 +140,7 @@ inputs = "*" | |||
| Jinja2 = "*" | |||
| lru-dict = "*" | |||
| matplotlib = "*" | |||
| metadrive-simulator = { version = "0.4.2.3", markers = "platform_machine != 'aarch64'" } # no linux/aarch64 wheels for certain dependencies | |||
| metadrive-simulator = {git = "https://github.com/metadriverse/metadrive.git", rev ="233a3a1698be7038ec3dd050ca10b547b4b3324c", markers = "platform_machine != 'aarch64'" } # no linux/aarch64 wheels for certain dependencies | |||
There was a problem hiding this comment.
can we just unpin it? have they done a release since that fix? I don't remember why we pinned it in the first place
There was a problem hiding this comment.
Unpinned. 0.4.2.3 is the last they did and that was before the fix
There was a problem hiding this comment.
oh then a git commit is fine if there's no release. just leave a comment to explain why so we can change it later
bongbui321
force-pushed
the
bump_metadrive
branch
from
76a7e02 to
09ae682
Compare
adeebshihadeh
changed the title
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
* bump metadrive * comment old-commit-hash: aa081f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prereq for #32513.
this includes this fix: metadriverse/metadrive#632