[autoconf] conan v2 #12896

jellespijker · 2022-09-11T13:06:28Z

Specify library name and version: autoconf/x.x.x

I took the liberty of defining a conf value: tools.autoconf:autoconf, tools.autoconf:autoreconf, tools.autoconf:autoheader, tools.autoconf:autom4te which are paths to the binary m4 executable. I don't know if tools is a reserved namespace but it maid sense in my mind. Let me know if that should change.

Based on this template:
https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/autotools_package

Contribute to CURA-8831

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

Note: test_package can't use the new Autools generator due to conan-io/conan#11975

From review comment

According review comment

KB-H013 states that everything needs to be installed under bin for tools. This also means that the `PATH` for the actual bin location `bin/bin` needs to be added to the `build_env`

Should fix KB-H071

subsystem isn't known at this time

No need to actually compile something with this tool we simply need to know if it runs. The win_bash for the run needs to be set explicitly due to the conf not working properly in the test_package see conan-io/conan#11975

This reverts commit d9ee4de.

This allows us to use the msys2 bash without using the conf_info in the test_package. Which is currently problematic due to: conan-io/conan#11975 Contributes to CURA-9574

Contributes to CURA-8831

The ducktyping seems to affect the usage of the Autotools in the main recipe as well Contributes to CURA-8831

Contributes to CURA-8831

The subsystem isn't known when consuming projects request the info Contributes to CURA-8831

Using some duck typing and inheritance to work around GH issue conan-io/conan#11980 Contributes to CURA-9595

Contribute to CURA-8831

Still an issue: conan-io/conan#11975 Contribute to CURA-8831

recipes/autoconf/all/conanfile.py

prince-chrismc

Matches what was discussed 👍

Unless there's a blocker I think fine tuning in the next PR is good :)

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

recipes/autoconf/all/conanfile.py

SpaceIm · 2022-10-31T15:07:11Z

recipes/autoconf/all/test_package/conanfile.py

+        if self._settings_build.os == "Windows" and not self.conf.get("tools.microsoft.bash:path", default=False, check_type=bool):
+            return  # autoconf needs a bash if there isn't a bash no need to build


shouldn't be merged in this state where windows is not tested, needs conan 1.53.0 in c3i

Why does this need 1.53? 👀

conan-io/conan#12095. So currently test is skipped on Windows, not good.

@jellespijker please remove this condition, now that conan 1.53.0 is dsployed, tools.microsoft.bash:path should be found in test package

recipes/autoconf/all/test_package/conanfile.py

SpaceIm · 2022-10-31T15:08:45Z

recipes/autoconf/all/test_package/conanfile.py

+        if can_run(self):
+            ext = ".exe" if self.settings.os == "Windows" else ""
+            test_cmd = unix_path(self, path.join(self.build_folder, f"test_package{ext}"))
+
+            self.run(test_cmd, env="conanbuild")


not need to protect with can_run, since it's executed in build scope.

Should this be run scope? Seems odd to be using build scope in a "can the test run" scenario 🤔

yes it should be run scope

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

conan-center-bot · 2022-11-02T08:57:59Z

Conan v1 pipeline

All green in build 17 (f76bdfe71b67d059c6162a4d0c64e67e7c14ce94):

autoconf/2.71@:
All packages built successfully! (All logs)
autoconf/2.69@:
All packages built successfully! (All logs)

uilianries

LGTM

SpaceIm · 2022-11-08T23:04:43Z

As I said in #12896 (comment), Windows is not tested, so I don't understand why it's approved. Actually it seems to break windows builds relying on autoreconf: #14110 (comment)

Where does it come from? tools.unix_path has been removed to env vars defined package_info(), so it breaks any Windows build calling autoconf.

SSE4 · 2022-11-09T09:45:25Z

As I said in #12896 (comment), Windows is not tested, so I don't understand why it's approved. Actually it seems to break windows builds relying on autoreconf: #14110 (comment)

Where does it come from? tools.unix_path has been removed to env vars defined package_info(), so it breaks any Windows build calling autoconf.

so, should we revert?

SpaceIm · 2022-11-09T10:15:41Z

At least still convert all paths in package_info() with legacy conans.tools.unix_path

hassec · 2022-11-21T21:07:48Z

@jellespijker did by any chance test that this recipe also runs from within msys2 ?

I've tried a bunch of different profiles to try to get

conan install -r conancenter autoconf/2.71@ -pr:b=default -pr:h=default --build=autoconf

to work but have had zero success with that.

jellespijker · 2022-11-22T11:31:17Z

these changes were instigated specifically for use because of the need to run it in msys2.

At the moment we're not using the chain of dependencies (in which autoconf is a part with) in production but it should work.

we planned on using it with this recipe https://github.com/Ultimaker/conan-ultimaker-index/blob/CURA-8831_pyqt6_recipe/recipes/pyqt6/conanfile.py using the following configuration https://github.com/Ultimaker/conan-config/tree/CURA-8831_pyqt6_recipe

which should work on Mac, Linux and Windows.

I'm gonna try if broke on msys2 somewhere this week and come back to you. But I suggest that if it is indeed broken for you that you create a bug report, so the CCI maintainers can process it in their normal workflow

hassec · 2022-11-22T21:25:01Z

@jellespijker Thanks for your prompt reply 😊 I've created an issue -> #14375

j.spijker@ultimaker.com and others added 26 commits September 1, 2022 16:58

autoconf v2 ready

551afba

Note: test_package can't use the new Autools generator due to conan-io/conan#11975

Revert removal of PATH from env_info

06a7499

From review comment

use unix_path instead of private import functions

4add446

According review comment

use unix_path instead of private import functions

bd244f2

According review comment

pass self to unix_path

4cd02ff

applied review comments

ea10b5a

KB-H013 states that everything needs to be installed under bin for tools. This also means that the `PATH` for the actual bin location `bin/bin` needs to be added to the `build_env`

Add licenses to package

ae5e36e

Explicitly use an empty includedirs

6ae0e3d

Should fix KB-H071

Merge branch 'conan-io:master' into autoconf-conan-v2

2108ccd

Fix setting unix_path for package_info

6aeafa2

subsystem isn't known at this time

simplified test_package

d9ee4de

No need to actually compile something with this tool we simply need to know if it runs. The win_bash for the run needs to be set explicitly due to the conf not working properly in the test_package see conan-io/conan#11975

Revert "simplified test_package"

f6fc785

This reverts commit d9ee4de.

use modern tools in test_package

357c078

add conan test_v1_package

b92480f

m4 is a build requirement

f97d01d

Ducktype Autotools configure and make

75e7579

This allows us to use the msys2 bash without using the conf_info in the test_package. Which is currently problematic due to: conan-io/conan#11975 Contributes to CURA-9574

Fix paths on windows in test method

2038f28

Contributes to CURA-8831

Don't ducktype but inherit

f321757

The ducktyping seems to affect the usage of the Autotools in the main recipe as well Contributes to CURA-8831

use unix_path for env_info

2187b09

Contributes to CURA-8831

remove extra lin

67efc0e

Contributes to CURA-8831

don't use unix_path

43c1014

The subsystem isn't known when consuming projects request the info Contributes to CURA-8831

fix subsystems on Windows

63ae4f9

Using some duck typing and inheritance to work around GH issue conan-io/conan#11980 Contributes to CURA-9595

updated autoconf for conan v2 ready support

36827a6

Contribute to CURA-8831

Merge branch 'conan-io:master' into CURA-8831_autoconf

29fe03c

autoconf bin contains shell scripts not executable

c5b382d

Contribute to CURA-8831

Removed Autotools workaround from test_package

e771b6f

Still an issue: conan-io/conan#11975 Contribute to CURA-8831

This was referenced Sep 11, 2022

[autoconf] add conan v2 support #12777

Closed

Conan 2.0 Migration Effort #12888

Closed

[bug] conf_info 'tools.microsoft.bash:subsystem' from msys2 is not used by Autotools in test_package conan-io/conan#11975

Closed

This comment has been minimized.

Sign in to view

jellespijker requested a review from uilianries October 29, 2022 15:12

prince-chrismc reviewed Oct 31, 2022

View reviewed changes

recipes/autoconf/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc previously approved these changes Oct 31, 2022

View reviewed changes

jwillikers previously approved these changes Oct 31, 2022

View reviewed changes

jellespijker dismissed stale reviews from jwillikers and prince-chrismc via f05d39a October 31, 2022 14:53

Update recipes/autoconf/all/conanfile.py

f05d39a

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

SpaceIm reviewed Oct 31, 2022

View reviewed changes

recipes/autoconf/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Oct 31, 2022

View reviewed changes

recipes/autoconf/all/test_package/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Oct 31, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

jwillikers previously approved these changes Oct 31, 2022

View reviewed changes

jellespijker dismissed jwillikers’s stale review via f76bdfe November 2, 2022 08:14

Apply suggestions from code review

f76bdfe

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

jwillikers approved these changes Nov 2, 2022

View reviewed changes

prince-chrismc approved these changes Nov 3, 2022

View reviewed changes

danimtb approved these changes Nov 7, 2022

View reviewed changes

uilianries approved these changes Nov 8, 2022

View reviewed changes

conan-center-bot merged commit 5b8511e into conan-io:master Nov 8, 2022

SpaceIm mentioned this pull request Nov 9, 2022

libsmacker: conan v2 support #14110

Merged

4 tasks

This was referenced Nov 9, 2022

autoconf: fix package info on windows #14118

Merged

[feature] Don't trick users in conan.tools.microsoft.unix_path with internal details like win_bash or subsystem conan-io/conan#12192

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[autoconf] conan v2 #12896

[autoconf] conan v2 #12896

jellespijker commented Sep 11, 2022

This comment has been minimized.

prince-chrismc left a comment

SpaceIm Oct 31, 2022

prince-chrismc Oct 31, 2022

SpaceIm Oct 31, 2022

SpaceIm Nov 7, 2022

SpaceIm Oct 31, 2022

prince-chrismc Oct 31, 2022

SpaceIm Oct 31, 2022

This comment has been minimized.

conan-center-bot commented Nov 2, 2022

uilianries left a comment

SpaceIm commented Nov 8, 2022 •

edited

Loading

SSE4 commented Nov 9, 2022

SpaceIm commented Nov 9, 2022

hassec commented Nov 21, 2022

jellespijker commented Nov 22, 2022

hassec commented Nov 22, 2022

		if self._settings_build.os == "Windows" and not self.conf.get("tools.microsoft.bash:path", default=False, check_type=bool):
		return # autoconf needs a bash if there isn't a bash no need to build

[autoconf] conan v2 #12896

[autoconf] conan v2 #12896

Conversation

jellespijker commented Sep 11, 2022

This comment has been minimized.

prince-chrismc left a comment

Choose a reason for hiding this comment

SpaceIm Oct 31, 2022

Choose a reason for hiding this comment

prince-chrismc Oct 31, 2022

Choose a reason for hiding this comment

SpaceIm Oct 31, 2022

Choose a reason for hiding this comment

SpaceIm Nov 7, 2022

Choose a reason for hiding this comment

SpaceIm Oct 31, 2022

Choose a reason for hiding this comment

prince-chrismc Oct 31, 2022

Choose a reason for hiding this comment

SpaceIm Oct 31, 2022

Choose a reason for hiding this comment

This comment has been minimized.

conan-center-bot commented Nov 2, 2022

Conan v1 pipeline

uilianries left a comment

Choose a reason for hiding this comment

SpaceIm commented Nov 8, 2022 • edited Loading

SSE4 commented Nov 9, 2022

SpaceIm commented Nov 9, 2022

hassec commented Nov 21, 2022

jellespijker commented Nov 22, 2022

hassec commented Nov 22, 2022

SpaceIm commented Nov 8, 2022 •

edited

Loading