[autoconf] conan v2 #12896
+178
−126
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,122 +1,131 @@ | ||
| from os import path | ||
|
|
||
| from conan import ConanFile | ||
| from conan.tools.env import VirtualBuildEnv | ||
| from conan.tools.files import copy, get, rmdir, apply_conandata_patches, replace_in_file, export_conandata_patches | ||
| from conan.tools.gnu import Autotools, AutotoolsToolchain, AutotoolsDeps | ||
| from conan.tools.layout import basic_layout | ||
| from conan.tools.microsoft import unix_path, is_msvc | ||
|
|
||
| required_conan_version = ">=1.52.0" | ||
|
|
||
|
|
||
| class AutoconfConan(ConanFile): | ||
| name = "autoconf" | ||
| description = "Autoconf is an extensible package of M4 macros that produce shell scripts to automatically configure software source code packages" | ||
| license = ("GPL-2.0-or-later", "GPL-3.0-or-later") | ||
| url = "https://github.com/conan-io/conan-center-index" | ||
| homepage = "https://www.gnu.org/software/autoconf/" | ||
| topics = ("autoconf", "configure", "build") | ||
| settings = "os", "arch", "compiler", "build_type" | ||
|
|
||
| @property | ||
| def _settings_build(self): | ||
| # TODO: Remove for Conan v2 | ||
| return getattr(self, "settings_build", self.settings) | ||
|
|
||
| def export_sources(self): | ||
| export_conandata_patches(self) | ||
|
|
||
| def configure(self): | ||
| self.win_bash = self._settings_build.os == "Windows" | ||
|
|
||
| def layout(self): | ||
| basic_layout(self, src_folder="src") | ||
|
|
||
| def requirements(self): | ||
| self.requires("m4/1.4.19") | ||
|
|
||
| def package_id(self): | ||
| self.info.clear() | ||
|
|
||
| def build_requirements(self): | ||
| if self._settings_build.os == "Windows" and not self.conf.get("tools.microsoft.bash:path", check_type=str): | ||
| self.tool_requires("msys2/cci.latest") | ||
| self.tool_requires("m4/1.4.19") | ||
|
|
||
| def source(self): | ||
| get(self, **self.conan_data["sources"][self.version], | ||
| destination=self.source_folder, strip_root=True) | ||
|
|
||
| def generate(self): | ||
| tc = AutotoolsToolchain(self) | ||
| tc.configure_args.extend([ | ||
| "--datarootdir=${prefix}/res", | ||
| ]) | ||
|
|
||
| if self.settings.os == "Windows": | ||
| if is_msvc(self): | ||
| build = "{}-{}-{}".format( | ||
| "x86_64" if self._settings_build.arch == "x86_64" else "i686", | ||
| "pc" if self._settings_build.arch == "x86" else "win64", | ||
| "mingw32") | ||
| host = "{}-{}-{}".format( | ||
| "x86_64" if self.settings.arch == "x86_64" else "i686", | ||
| "pc" if self.settings.arch == "x86" else "win64", | ||
| "mingw32") | ||
| tc.configure_args.append(f"--build={build}") | ||
| tc.configure_args.append(f"--host={host}") | ||
|
|
||
| env = tc.environment() | ||
| env.define("INSTALL", unix_path(self, path.join(self.source_folder, 'build-aux', 'install-sh'))) | ||
| tc.generate(env) | ||
|
|
||
| deps = AutotoolsDeps(self) | ||
| deps.generate() | ||
|
|
||
| ms = VirtualBuildEnv(self) | ||
| ms.generate(scope="build") | ||
|
|
||
| def build(self): | ||
| apply_conandata_patches(self) | ||
| replace_in_file(self, path.join(self.source_folder, "Makefile.in"), "M4 = /usr/bin/env m4", "#M4 = /usr/bin/env m4") | ||
|
|
||
| autotools = Autotools(self) | ||
| autotools.configure() | ||
| autotools.make() | ||
|
|
||
| def package(self): | ||
| autotools = Autotools(self) | ||
| autotools.install(args=[f"DESTDIR={unix_path(self, self.package_folder)}"]) # Need to specify the `DESTDIR` as a Unix path, aware of the subsystem | ||
|
|
||
| copy(self, "COPYING*", src=self.source_folder, dst=path.join(self.package_folder, "licenses")) | ||
| rmdir(self, path.join(self.package_folder, "res", "info")) | ||
| rmdir(self, path.join(self.package_folder, "res", "man")) | ||
|
|
||
| def package_info(self): | ||
| self.cpp_info.libdirs = [] | ||
| self.cpp_info.includedirs = [] | ||
|
|
||
| bin_path = path.join(self.package_folder, "bin") | ||
| self.output.info(f"Appending PATH environment variable: {bin_path}") | ||
| self.env_info.PATH.append(bin_path) | ||
|
|
||
| dataroot_path = path.join(self.package_folder, "res", "autoconf") | ||
| self.output.info(f"Defining AC_MACRODIR environment variable: {dataroot_path}") | ||
| self.env_info.AC_MACRODIR = dataroot_path | ||
| self.buildenv_info.define_path("AC_MACRODIR", dataroot_path) | ||
|
|
||
| self.output.info(f"Defining AUTOM4TE_PERLLIBDIR environment variable: {dataroot_path}") | ||
| self.env_info.AUTOM4TE_PERLLIBDIR = dataroot_path | ||
| self.buildenv_info.define_path("AUTOM4TE_PERLLIBDIR", dataroot_path) | ||
|
|
||
| autoconf_bin = path.join(bin_path, "autoconf") | ||
| self.output.info(f"Defining AUTOCONF environment variable: {autoconf_bin}") | ||
| self.env_info.AUTOCONF = autoconf_bin | ||
| self.buildenv_info.define_path("AUTOCONF", autoconf_bin) | ||
|
|
||
| autoreconf_bin = path.join(bin_path, "autoreconf") | ||
| self.output.info(f"Defining AUTORECONF environment variable: {autoreconf_bin}") | ||
| self.env_info.AUTORECONF = autoreconf_bin | ||
| self.buildenv_info.define_path("AUTORECONF", autoreconf_bin) | ||
|
|
||
| autoheader_bin = path.join(bin_path, "autoheader") | ||
| self.output.info(f"Defining AUTOHEADER environment variable: {autoheader_bin}") | ||
| self.env_info.AUTOHEADER = autoheader_bin | ||
| self.buildenv_info.define_path("AUTOHEADER", autoheader_bin) | ||
|
|
||
| autom4te_bin = path.join(bin_path, "autom4te") | ||
| self.output.info(f"Defining AUTOM4TE environment variable: {autom4te_bin}") | ||
| self.env_info.AUTOM4TE = autom4te_bin | ||
| self.buildenv_info.define_path("AUTOM4TE", autom4te_bin) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,47 +1,53 @@ | ||
| import shutil | ||
| from os import path | ||
|
|
||
| from conan import ConanFile | ||
| from conan.tools.build import can_run | ||
| from conan.tools.gnu import Autotools | ||
| from conan.tools.microsoft import unix_path | ||
|
|
||
| required_conan_version = ">=1.50.0" | ||
|
|
||
|
|
||
| class TestPackageConan(ConanFile): | ||
| settings = "os", "compiler", "build_type", "arch" | ||
| exports_sources = "configure.ac", "config.h.in", "Makefile.in", "test_package_c.c", "test_package_cpp.cpp", | ||
| generators = "AutotoolsDeps", "AutotoolsToolchain", "VirtualBuildEnv" | ||
| test_type = "explicit" | ||
|
|
||
| @property | ||
| def _settings_build(self): | ||
| # TODO: Remove for Conan v2 | ||
| return getattr(self, "settings_build", self.settings) | ||
|
|
||
| @property | ||
| def win_bash(self): | ||
| return self._settings_build.os == "Windows" | ||
|
|
||
| def build_requirements(self): | ||
| if self._settings_build.os == "Windows" and not self.conf.get("tools.microsoft.bash:path", default=False, check_type=bool): | ||
| self.tool_requires("msys2/cci.latest") # The conf `tools.microsoft.bash:path` and `tools.microsoft.bash:subsystem` aren't injected for test_package | ||
| self.tool_requires(self.tested_reference_str) | ||
|
|
||
| def build(self): | ||
| if self._settings_build.os == "Windows" and not self.conf.get("tools.microsoft.bash:path", default=False, check_type=bool): | ||
| return # autoconf needs a bash if there isn't a bash no need to build | ||
|
Comment on lines
+33
to
+34
There was a problem hiding this comment. shouldn't be merged in this state where windows is not tested, needs conan 1.53.0 in c3i There was a problem hiding this comment. Why does this need 1.53? 👀 There was a problem hiding this comment. conan-io/conan#12095. So currently test is skipped on Windows, not good. There was a problem hiding this comment. @jellespijker please remove this condition, now that conan 1.53.0 is dsployed, |
||
|
|
||
| for src in self.exports_sources: | ||
| shutil.copy(path.join(self.source_folder, src), self.build_folder) | ||
|
|
||
| self.run("autoconf --verbose") | ||
|
|
||
| autotools = Autotools(self) | ||
| autotools.configure(build_script_folder=self.build_folder) | ||
| autotools.make() | ||
|
|
||
| def test(self): | ||
| if self._settings_build.os == "Windows" and not self.conf.get("tools.microsoft.bash:path", default=False, check_type=bool): | ||
| return # autoconf needs a bash if there isn't a bash no need to build | ||
|
|
||
| if can_run(self): | ||
| ext = ".exe" if self.settings.os == "Windows" else "" | ||
| test_cmd = unix_path(self, path.join(self.build_folder, f"test_package{ext}")) | ||
|
|
||
| self.run(test_cmd, env="conanbuild") | ||
|
Comment on lines
+49
to
+53
There was a problem hiding this comment. not need to protect with can_run, since it's executed in build scope. There was a problem hiding this comment. Should this be run scope? Seems odd to be using build scope in a "can the test run" scenario 🤔 There was a problem hiding this comment. yes it should be run scope |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| from conans import AutoToolsBuildEnvironment, ConanFile, tools | ||
| from conan.tools.microsoft import is_msvc, unix_path | ||
| import contextlib | ||
| import os | ||
| import shutil | ||
|
|
||
| required_conan_version = ">=1.45.0" | ||
|
|
||
|
|
||
| class TestPackageConan(ConanFile): | ||
| settings = "os", "compiler", "build_type", "arch" | ||
| exports_sources = "../test_package/configure.ac", "../test_package/config.h.in", "../test_package/Makefile.in", "../test_package/test_package_c.c", "../test_package/test_package_cpp.cpp", | ||
| test_type = "explicit" | ||
|
|
||
| @property | ||
| def _settings_build(self): | ||
| return getattr(self, "settings_build", self.settings) | ||
|
|
||
| def build_requirements(self): | ||
| self.build_requires(self.tested_reference_str) | ||
| if self._settings_build.os == "Windows" and not tools.get_env("CONAN_BASH_PATH"): | ||
| self.build_requires("msys2/cci.latest") | ||
|
|
||
| @contextlib.contextmanager | ||
| def _build_context(self): | ||
| if is_msvc(self): | ||
| with tools.vcvars(self): | ||
| with tools.environment_append({"CC": "cl -nologo", "CXX": "cl -nologo",}): | ||
| yield | ||
| else: | ||
| yield | ||
|
|
||
| def build(self): | ||
| for src in self.exports_sources: | ||
| shutil.copy(os.path.join(self.source_folder, src), self.build_folder) | ||
| self.run("autoconf --verbose", | ||
| win_bash=tools.os_info.is_windows, run_environment=True) | ||
| self.run("{} --help".format(os.path.join(self.build_folder, "configure").replace("\\", "/")), | ||
| win_bash=tools.os_info.is_windows, run_environment=True) | ||
| autotools = AutoToolsBuildEnvironment(self, win_bash=tools.os_info.is_windows) | ||
| with self._build_context(): | ||
| autotools.configure() | ||
| autotools.make() | ||
|
|
||
| def test(self): | ||
| if not tools.cross_building(self): | ||
| self.run(os.path.join(".", "test_package"), run_environment=True) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't work with
if hasattr(self, "settings_build"):? It's important to avoid issues with 1 profile.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SpaceIm I'm not sure what you mean with this comment;
self._settings_buildreturns either thesettings_buildif available but falls back onsettings. So I believe it should work for 1 profile and a build/host profile.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 profile is deprecated, this will help alter consumers to upgrade their usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this strategy. It's not a good user experience to break such things brutally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still using
-pronly, as I have problems with some packages and-pr:b and -pr:h,so if one package won't with with -pr, and others won't work with -pr:b and -pr:h then we have a gridlock situation.
I'd instead suggest a warning in the conan client with a link to an issue where people can report problematic recipes that they discover using the dual-profiles...
I can start testing again with the dual profiles and look for errors.