Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving conf_info from BR inherited by consumers' test_package #12095

Merged
merged 9 commits into from
Sep 21, 2022

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Sep 12, 2022

Changelog: Fix: Fixed a bug when getting the values from the self.conf in the conanfile of a test_package with build_requirements declaring the self.conf_info.
Docs: omit

The issue is in conan 1.x , the test_package conanfile cannot read (loses) the conf inherited from the build requires.
It works for 2.x BUT this is a conan-center-index recipes migration issue so we should provide the fix.

Closes #11975

@lasote lasote added this to the 1.53 milestone Sep 12, 2022
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this is looking good, but there are a bunch of tests broken, it is not evident what is happening, should be investigated

@lasote
Copy link
Contributor Author

lasote commented Sep 13, 2022

I'd say this is looking good, but there are a bunch of tests broken, it is not evident what is happening, should be investigated

Yes, I saw. I think I shouldn't override the conan_file.conf. attribute but append it, to avoid possible None values being assigned and overwriting the values for the profile. I'll investigate.

@lasote lasote changed the title POC for solving https://github.com/conan-io/conan/issues/11975 Solving conf_info from BR inherited by consumers' test_package Sep 14, 2022
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
@memsharded memsharded self-assigned this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] conf_info 'tools.microsoft.bash:subsystem' from msys2 is not used by Autotools in test_package
3 participants