-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solving conf_info from BR inherited by consumers' test_package #12095
Solving conf_info from BR inherited by consumers' test_package #12095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say this is looking good, but there are a bunch of tests broken, it is not evident what is happening, should be investigated
Yes, I saw. I think I shouldn't override the |
conans/test/integration/toolchains/env/test_virtualenv_winbash.py
Outdated
Show resolved
Hide resolved
conans/test/integration/toolchains/env/test_virtualenv_winbash.py
Outdated
Show resolved
Hide resolved
conans/test/integration/toolchains/env/test_virtualenv_winbash.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
Changelog: Fix: Fixed a bug when getting the values from the
self.conf
in the conanfile of atest_package
with build_requirements declaring theself.conf_info
.Docs: omit
The issue is in conan 1.x , the test_package conanfile cannot read (loses) the
conf
inherited from the build requires.It works for 2.x BUT this is a conan-center-index recipes migration issue so we should provide the fix.
Closes #11975