Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qhull: add libqhullcpp component, add v8.1-alpha4 #24532

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 5, 2024

Summary

Changes to recipe: qhull/cci.20231130

Motivation

The qhull recipe currently does not export the libqhullcpp component, which is required by:

I also added the latest head commit version to the recipe, since the development version includes a few useful changes, such as qhull/qhull#76 (thanks, @SpaceIm!).

Dropped v8.0.0, which is redundant to v8.0.1 and not used in any recipes.

Details

The cpp component is only available with the newly added version since I did not want to modify the existing patches.

Like the reentrant option, the cpp component is always built, but only exposed in package_info() when the option is enabled.

I had to re-enable the building and installing of the non-reentrant shared C library for backwards compatibility in the latest version.


@valgur
Copy link
Contributor Author

valgur commented Jul 5, 2024

cilantro builds fine locally with an unvendored libqhullcpp library after these changes: valgur@b73a6bc

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Jul 9, 2024

Would it be possible to ask upstream a release in order to avoid a custom cci version?

@AbrilRBS
Copy link
Member

AbrilRBS commented Jul 9, 2024

Would it be possible to ask upstream a release in order to avoid a custom cci version?

This would be ideal @SpaceIm @valgur :)

@AbrilRBS AbrilRBS self-assigned this Jul 9, 2024
valgur added a commit to valgur/conan-center-index that referenced this pull request Jul 9, 2024
@valgur valgur changed the title qhull: add libqhullcpp component, add latest head version qhull: add libqhullcpp component, add v8.1-alpha4 Jul 26, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (36811bf6d67682aa7b527634e6479adccaf456b4):

  • qhull/7.3.2:
    All packages built successfully! (All logs)

  • qhull/8.1-alpha4:
    All packages built successfully! (All logs)

  • qhull/8.0.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (36811bf6d67682aa7b527634e6479adccaf456b4):

  • qhull/8.0.1:
    All packages built successfully! (All logs)

  • qhull/7.3.2:
    All packages built successfully! (All logs)

  • qhull/8.1-alpha4:
    All packages built successfully! (All logs)

@valgur valgur requested a review from AbrilRBS July 26, 2024 19:01
@perseoGI
Copy link
Contributor

Would it be possible to ask upstream a release in order to avoid a custom cci version?

@valgur @SpaceIm did you have some time to request for a semantic release schema at upstream? https://github.com/qhull/qhull/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen

@valgur
Copy link
Contributor Author

valgur commented Jul 29, 2024

@perseoGI I asked and they kindly created a new pre-release: qhull/qhull#128 (comment)
I've already updated the recipe accordingly.

@shkwon98
Copy link

@jcar87 @uilianries @AbrilRBS
I'm really looking forward to it being merged...!

@perseoGI
Copy link
Contributor

perseoGI commented Nov 15, 2024

I've just launched the new CI for this PR. Once CI is green, I'll review! 🐸

@shkwon98
Copy link

shkwon98 commented Nov 18, 2024

@perseoGI
Is there any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Why is libqhullcpp excluded from all qhull packages? [request] qhull/8.0.2
6 participants