-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qhull: add libqhullcpp
component, add v8.1-alpha4
#24532
base: master
Are you sure you want to change the base?
Conversation
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Would it be possible to ask upstream a release in order to avoid a custom cci version? |
libqhullcpp
component, add latest head versionlibqhullcpp
component, add v8.1-alpha4
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 6 (
Conan v2 pipeline ✔️
All green in build 6 ( |
@valgur @SpaceIm did you have some time to request for a semantic release schema at upstream? https://github.com/qhull/qhull/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen |
@perseoGI I asked and they kindly created a new pre-release: qhull/qhull#128 (comment) |
@jcar87 @uilianries @AbrilRBS |
I've just launched the new CI for this PR. Once CI is green, I'll review! 🐸 |
@perseoGI |
Summary
Changes to recipe: qhull/cci.20231130
Motivation
The
qhull
recipe currently does not export thelibqhullcpp
component, which is required by:I also added the latest head commit version to the recipe, since the development version includes a few useful changes, such as qhull/qhull#76 (thanks, @SpaceIm!).
Dropped v8.0.0, which is redundant to v8.0.1 and not used in any recipes.
Details
The cpp component is only available with the newly added version since I did not want to modify the existing patches.
Like the
reentrant
option, thecpp
component is always built, but only exposed inpackage_info()
when the option is enabled.I had to re-enable the building and installing of the non-reentrant shared C library for backwards compatibility in the latest version.