Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onnxruntime-cpp dependency and verify that required Python modules are installed #52

Closed
wants to merge 6 commits into from

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 19, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro traversaro added the automerge Merge the PR when CI passes label Jan 19, 2024
@traversaro
Copy link
Contributor Author

🤔 It's not able to load onnxruntime in the tests https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=861052&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=986b1512-c876-5f92-0d81-ba851554a0a3&l=8909

Ah, I think it is the problem described in conda-forge/onnxruntime-feedstock#78 . The discussion there kind of went stale, but I think for now we can just pin onnxruntime-cpp and manually add a run exports.

Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Jan 19, 2024
@traversaro
Copy link
Contributor Author

🤔 It's not able to load onnxruntime in the tests https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=861052&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=986b1512-c876-5f92-0d81-ba851554a0a3&l=8909

Ah, I think it is the problem described in conda-forge/onnxruntime-feedstock#78 . The discussion there kind of went stale, but I think for now we can just pin onnxruntime-cpp and manually add a run exports.

Ok, I proposed the proper fix in conda-forge/onnxruntime-feedstock#102 .

@traversaro
Copy link
Contributor Author

Interestingly, the Windows failure is:

-------------------------------------------------------------------------------
QP-IK [Distance and Gravity tasks Unconstrained]
-------------------------------------------------------------------------------
D:\bld\bipedal-locomotion-framework_1705663992921\work\src\IK\tests\QPInverseKinematicsTest.cpp(858)
...............................................................................

D:\bld\bipedal-locomotion-framework_1705663992921\work\src\IK\tests\QPInverseKinematicsTest.cpp(979): FAILED:
  REQUIRE( toManifPose(kinDyn->getWorldTransform(desiredSetPoints.targetFrameDistance)) .translation() .norm() == Catch::Approx(desiredSetPoints.targetDistance).epsilon(tolerance) )
with expansion:
  76.8941567337 == Approx( 1.3854129089 )

===============================================================================
test cases:   5 |   4 passed | 1 failed
assertions: 661 | 660 passed | 1 failed

the same of ami-iit/bipedal-locomotion-framework#799 .

@GiulioRomualdi
Copy link
Contributor

Thanks to @traversaro ami-iit/bipedal-locomotion-framework#800 fixes the issue, I can release a new version of the project and generate a new package from it so we don't need to add any patch

@traversaro
Copy link
Contributor Author

Thanks to @traversaro ami-iit/bipedal-locomotion-framework#800 fixes the issue, I can release a new version of the project and generate a new package from it so we don't need to add any patch

We can also just skip the test in the build script by passing -E to ctest.

@traversaro traversaro added the automerge Merge the PR when CI passes label Jan 22, 2024
@traversaro
Copy link
Contributor Author

Thanks to @traversaro ami-iit/bipedal-locomotion-framework#800 fixes the issue, I can release a new version of the project and generate a new package from it so we don't need to add any patch

We can also just skip the test in the build script by passing -E to ctest.

Done in 448dd32 .

@traversaro
Copy link
Contributor Author

Superseded by #53 .

@traversaro traversaro closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants