Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_exports for onnxruntime-cpp without modifying SOVERSION #102

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 19, 2024

Variant of #78 (thanks @kuepe-sl) to add run_exports to onnxruntime-cpp, without modifying SOVERSION.

This does not halts the discussion ongoing in #78, but solves the specific problem of adding run_exports to onnxruntime-cpp . If a consensus is reached to relax run_exports condition in the future, we can always do that in the future. However, there is no need to make the better (relaxed run_exports) enemy of the good (fixing the missing run_exports).

fyi @conda-forge/onnxruntime

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@xhochy xhochy added the automerge Merge the PR when CI passes label Jan 19, 2024
@github-actions github-actions bot merged commit 64f9877 into conda-forge:main Jan 19, 2024
82 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants