Bump to version 1.9.0

[valeriupredoi]

Hello @conda-forge/prospector folks, we are big fans of prospector and have been using it for a while now; unfortunately the noarch one on conda-forge is rather old (1.7.7) and we'd like to move on to support Python=3.11, and use the latest prospector. So I am opening this see maybe I can help with the conda package for 1.9.0 - hope you don't mind me doing so 🍺

Closes #35 #36 #37 #38

Checklist

• Used a personal fork of the feedstock to propose changes
• [ ] Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[valeriupredoi]

@conda-forge-admin, please rerender

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

• Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[valeriupredoi]

OK folks, I have now included all the v1.9.0 up to date packages and their pins, but there is one roadblock: requirements-detector that is only at 0.7 on conda-forge; I have opened a PR to bump the version on their feedstock at conda-forge/requirements-detector-feedstock#18 - but until that gets resolved, any way the >=1.0.3 pin you have can be relaxed? 🍺

[valeriupredoi]

OK folks, some progress update wrt requirements-detector - I have identified the pkg that blocks the update of that, and opened prospector-dev/requirements-detector#44 to retire it, also my colleague @zklaus is making requirements-detector noarch in conda-forge/requirements-detector-feedstock#19

[valeriupredoi]

requirements-detector is now built and updated with version 1.2.1

[valeriupredoi]

@zklaus @jakirkham - tests pass well now yay! Still a bit of cleanup to be done, will try do it later today from the airport, but we on a good path 😁

[valeriupredoi]

Cleaning up (on phone, so need to do it line by line, no multiline code suggestions on Android/Chrome)

[valeriupredoi]

Ok folks, @zklaus @jakirkham @bouweandela I have now cleaned up the recipe (apologies for the clunky set of commits, doing this off my phone), I think we should be good to merge this. The reason why I tag Klaus and Bouwe is that it may be a good idea for all three of us to be repo maintainers here - since we use prospector actively, we could fix things here in good time, and get a bit of the burden off the other maintainers, but I'll leave that up to you @jakirkham - a next PR maybe to add us as maintainers. Cheers 🍺

[valeriupredoi]

friendly ping @conda-forge/prospector folks 🍺

[jakirkham]

Thanks @valeriupredoi! 🙏

Sorry for the slow reply here

Provided a few minor suggestions below

Wonder if we should sort the requirements here to match upstream (to improve readability) or suggest upstream sort them alphabetically (maybe with optional dependencies at the end of the list). This would simplify the review of changes in dependency constraints (or added/dropped dependencies). Just a thought 🙂

[jakirkham]

Also do you want to add yourself as a maintainer here?

[valeriupredoi]

@jakirkham great to have your reply and review, mate, very many thanks! I have plugged in the suggested deps changes - good spotting and alignment with upstream! I have also added myself as repo maintainer/codeowner here; about sorting the deps - totally with you on that, but if they don't do it upstream, we should probably just wait on them to first do it there. Can suggest that via a PR sometime, my main priority is to first get this outta the way so we can finally Py311 it 😁

[valeriupredoi]

@conda-forge-admin, please rerender

[jakirkham]

Thanks @valeriupredoi! 🙏

Yeah dependency ordering is not a blocker. Mostly noting since there are a lot of dependencies and it is a little hard atm to compare line-by-line atm with different ordering schemes. So it seems like something we would want to improve for maintainability reasons. Maybe we can track this in an issue

Thanks again for all your hard work here ❤️

[valeriupredoi]

@jakirkham you are a legend! Great many thanks! I shall open an issue and to upstream suggesting reordering their deps, maybe even a PR if I feel generous - will defo fix it here once they do that upstream. Cheers muchly for all the help here 🍺