Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to noarch: python #19

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Conversation

zklaus
Copy link

@zklaus zklaus commented Apr 20, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #16

This converts this feedstock to noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zklaus
Copy link
Author

zklaus commented Apr 20, 2023

@conda-forge-admin, please rerender

@zklaus zklaus marked this pull request as ready for review April 20, 2023 10:06
@zklaus zklaus requested a review from jakirkham as a code owner April 20, 2023 10:06
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to see this going @zklaus - note that I am approving w/o any maintainer rights though. There is one more roadblock in front of a nifty conda package update - the use of poetry-semver that is now archived and old, and it's not on conda-forge, but for that I opened prospector-dev/requirements-detector#44 🍺

@jakirkham
Copy link
Member

So how should we handle this? Merge #18 or #19 first?

@zklaus
Copy link
Author

zklaus commented Apr 21, 2023

I personally would do this one (#19) first. Since this old version of requirements-detector seems to work without the complicated dependency, we get one more version for free and have a better separation of issues.

@valeriupredoi
Copy link
Contributor

@jakirkham cheers for getting back to us, mate! I am with @zklaus on this one. I can merge the new noarch into #18 and we do a clean, noarch release of the latest version 👍

@jakirkham jakirkham merged commit 921ab24 into conda-forge:main Apr 21, 2023
@jakirkham
Copy link
Member

Thanks you both! 🙏

@valeriupredoi
Copy link
Contributor

many thanks @jakirkham 🍺

@valeriupredoi valeriupredoi mentioned this pull request Apr 21, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to noarch
3 participants