Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to v1.2.1 #18

Merged
merged 12 commits into from
Apr 22, 2023
Merged

bump version to v1.2.1 #18

merged 12 commits into from
Apr 22, 2023

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Apr 19, 2023

Hi @conda-forge/requirements-detector @jakirkham I am in the middle of Py311ing our package and we need prospector at latest, and prospector needs requirements-detector>=1.0.3, was wondering if I can help build a newer one here, hope you don't mind 🍺

Checklist

  • Used a personal fork of the feedstock to propose changes
  • [ ] Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #20
Closes #17
Closes #15
Closes #14

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@valeriupredoi
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@valeriupredoi
Copy link
Contributor Author

adapting this since there is now a new and fully conda-forgeable version 1.2.1 https://pypi.org/project/requirements-detector/

@valeriupredoi valeriupredoi changed the title bump version to v1.1.0 bump version to v1.2.1 Apr 20, 2023
@valeriupredoi
Copy link
Contributor Author

@conda-forge-admin, please rerender

@valeriupredoi
Copy link
Contributor Author

@zklaus heads up the new 1.2.1 version works beautifully for conda-forge-only deps, so you may want to let this through first then noarch it as in #19 - up to you and @jakirkham - this is ready, cheers to @carlio upstream for the very prompt release!

@jakirkham jakirkham mentioned this pull request Apr 21, 2023
5 tasks
@valeriupredoi
Copy link
Contributor Author

now that #19 has been merged I will have to tweak this to get in the noarch structure - unfortunately I'll have limited time next week, so by all means, if others want to do it - go ahead - maybe @jakirkham if you got a bit of time, worst case scenario I'll fix it first week of May 🍺

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/requirements-detector-feedstock/actions/runs/4768297500.

@jakirkham jakirkham requested a review from zklaus as a code owner April 21, 2023 19:51
@jakirkham
Copy link
Member

jakirkham commented Apr 21, 2023

@valeriupredoi, no worries

In general with these conflicts would only worry about fixing up recipe/ content and (when relevant conda-forge.yml content). The rest of the files can easily be regenerated with a re-render. So just pushing those through with some conflict resolution is usually good enough to get to the point where re-rendering can be done

Went ahead and did this above. Though hope that helps simplify the steps in the future 🙂

Can you please look over and make sure things look ok (or fix them if not)? Thanks! 🙏

@valeriupredoi
Copy link
Contributor Author

ace @jakirkham - cheers muchly for bringing in those noarch changes, all looks great to me, tests pass, and I reckon we have us a nice new and py311-supporting version! Many thanks for all the help here, mate 🍺

@jakirkham jakirkham merged commit fc59dcb into conda-forge:main Apr 22, 2023
@jakirkham
Copy link
Member

Great thanks for double checking and the much needed work to refresh things here! 🙏

@jakirkham jakirkham mentioned this pull request Apr 22, 2023
3 tasks
@valeriupredoi
Copy link
Contributor Author

Brilliant, cheers @jakirkham 🍺 On to prospector now, no rest for the wicked 😁 Flying to a conference today, will try sort out the prospector update from Heathrow, mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants