Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve github actions #13358

Merged
merged 9 commits into from
Sep 21, 2022
Merged

ci: improve github actions #13358

merged 9 commits into from
Sep 21, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 21, 2022

Description

ref: #12805


@marbar3778, if we merge this we should check the required actions (we want to add the build job and the integration job as required too)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review September 21, 2022 16:27
@julienrbrt julienrbrt requested a review from a team as a code owner September 21, 2022 16:27
go.mod Outdated Show resolved Hide resolved
tests/Makefile Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #13358 (5edef43) into main (4fe7797) will decrease coverage by 1.10%.
The diff coverage is 28.00%.

❗ Current head 5edef43 differs from pull request most recent head d4efed4. Consider uploading reports for the commit d4efed4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13358      +/-   ##
==========================================
- Coverage   55.87%   54.77%   -1.11%     
==========================================
  Files         646      652       +6     
  Lines       54895    55847     +952     
==========================================
- Hits        30675    30590      -85     
- Misses      21762    22782    +1020     
- Partials     2458     2475      +17     
Impacted Files Coverage Δ
baseapp/grpcrouter.go 90.00% <ø> (ø)
baseapp/grpcrouter_helpers.go 25.00% <ø> (ø)
baseapp/grpcserver.go 1.72% <ø> (ø)
baseapp/msg_service_router.go 85.29% <ø> (+4.41%) ⬆️
baseapp/options.go 67.92% <0.00%> (-0.60%) ⬇️
client/broadcast.go 51.54% <ø> (ø)
client/cmd.go 57.73% <ø> (ø)
client/context.go 54.49% <ø> (-1.79%) ⬇️
client/flags/flags.go 19.35% <ø> (-0.32%) ⬇️
client/grpc_query.go 15.38% <ø> (+15.38%) ⬆️
... and 229 more

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Love seeing GA introduce some much needed features.

I can remove require on old actions to merge.

@tac0turtle tac0turtle enabled auto-merge (squash) September 21, 2022 22:52
auto-merge was automatically disabled September 21, 2022 22:53

Base branch was modified

@tac0turtle tac0turtle merged commit c297caa into main Sep 21, 2022
@tac0turtle tac0turtle deleted the julien/fix-gh-workflow branch September 21, 2022 22:57
@julienrbrt
Copy link
Member Author

julienrbrt commented Sep 22, 2022

Do we want to backport that? Thinking about it, we cannot backport everything as it is dependent to the tests refactor.

@julienrbrt julienrbrt mentioned this pull request Sep 22, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants