chore: linting fixes #19978
chore: linting fixes #19978
Conversation
WalkthroughWalkthroughThe recent updates primarily focus on enhancing gRPC client initialization and connection setup, alongside a significant adjustment in error handling within a migration test function. Additionally, the removal of a problematic type in the RocksDB configuration and the introduction of new imports in specific modules for better protocol handling mark notable improvements. These changes collectively aim at refining the system's stability and compatibility with protocol buffers. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -168,7 +168,7 @@ func ReadPersistentCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Cont | |||
| }))) | |||
| } | |||
|
|
|||
| grpcClient, err := grpc.Dial(grpcURI, dialOpts...) | |||
| grpcClient, err := grpc.NewClient(grpcURI, dialOpts...) | |||
There was a problem hiding this comment.
Replace grpc.NewClient with grpc.Dial for creating a gRPC client connection.
- grpcClient, err := grpc.NewClient(grpcURI, dialOpts...)
+ grpcClient, err := grpc.Dial(grpcURI, dialOpts...)The correct function to establish a gRPC connection is grpc.Dial, not grpc.NewClient. This change ensures compatibility with the gRPC package's API and correct initialization of the gRPC client.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| grpcClient, err := grpc.NewClient(grpcURI, dialOpts...) | |
| grpcClient, err := grpc.Dial(grpcURI, dialOpts...) |
| @@ -473,7 +473,7 @@ func startGrpcServer( | |||
| } | |||
|
|
|||
| // if gRPC is enabled, configure gRPC client for gRPC gateway | |||
| grpcClient, err := grpc.Dial( | |||
| grpcClient, err := grpc.NewClient( | |||
There was a problem hiding this comment.
Replace grpc.NewClient with grpc.DialContext.
The grpc.NewClient function does not exist in the gRPC Go library. To establish a gRPC client connection, use grpc.DialContext instead, which allows passing a context and setting up connection options appropriately.
- grpcClient, err := grpc.NewClient(
+ grpcClient, err := grpc.DialContext(
ctx,
config.Address,
grpc.WithTransportCredentials(insecure.NewCredentials()),
grpc.WithDefaultCallOptions(
grpc.ForceCodec(codec.NewProtoCodec(clientCtx.InterfaceRegistry).GRPCCodec()),
grpc.MaxCallRecvMsgSize(maxRecvMsgSize),
grpc.MaxCallSendMsgSize(maxSendMsgSize),
),
)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| grpcClient, err := grpc.NewClient( | |
| grpcClient, err := grpc.DialContext( | |
| ctx, | |
| config.Address, | |
| grpc.WithTransportCredentials(insecure.NewCredentials()), | |
| grpc.WithDefaultCallOptions( | |
| grpc.ForceCodec(codec.NewProtoCodec(clientCtx.InterfaceRegistry).GRPCCodec()), | |
| grpc.MaxCallRecvMsgSize(maxRecvMsgSize), | |
| grpc.MaxCallSendMsgSize(maxSendMsgSize), | |
| ), | |
| ) |
| @@ -55,7 +55,7 @@ func (s *TestSuite) SetupTest() { | |||
|
|
|||
| s.cdc = encodingConfig | |||
|
|
|||
| grpcConn, err := grpc.Dial( | |||
| grpcConn, err := grpc.NewClient( | |||
There was a problem hiding this comment.
Replace grpc.NewClient with grpc.Dial or grpc.DialContext.
The grpc.NewClient function does not exist in the gRPC Go API. To establish a gRPC connection, use grpc.Dial or grpc.DialContext with the appropriate options.
- grpcConn, err := grpc.NewClient(
+ grpcConn, err := grpc.DialContext(Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| grpcConn, err := grpc.NewClient( | |
| grpcConn, err := grpc.DialContext( |
| @@ -174,7 +174,7 @@ func (c *ChainInfo) OpenClient() (*grpc.ClientConn, error) { | |||
| } | |||
|
|
|||
| var err error | |||
| c.client, err = grpc.Dial(endpoint.Endpoint, grpc.WithTransportCredentials(creds)) | |||
| c.client, err = grpc.NewClient(endpoint.Endpoint, grpc.WithTransportCredentials(creds)) | |||
There was a problem hiding this comment.
Replace grpc.NewClient with grpc.Dial or grpc.DialContext.
The grpc.NewClient function does not exist in the gRPC Go API. To establish a gRPC connection, use grpc.Dial or grpc.DialContext with the appropriate options.
- c.client, err = grpc.NewClient(endpoint.Endpoint, grpc.WithTransportCredentials(creds))
+ c.client, err = grpc.Dial(endpoint.Endpoint, grpc.WithTransportCredentials(creds))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| c.client, err = grpc.NewClient(endpoint.Endpoint, grpc.WithTransportCredentials(creds)) | |
| c.client, err = grpc.Dial(endpoint.Endpoint, grpc.WithTransportCredentials(creds)) |
| @@ -175,7 +175,7 @@ func getGRPCClient(grpcConfig GRPCConfig) (*grpc.ClientConn, error) { | |||
| } | |||
|
|
|||
| dialOptions := []grpc.DialOption{transport} | |||
| grpcClient, err := grpc.Dial(grpcConfig.Address, dialOptions...) | |||
| grpcClient, err := grpc.NewClient(grpcConfig.Address, dialOptions...) | |||
There was a problem hiding this comment.
Replace grpc.NewClient with grpc.Dial or grpc.DialContext.
The grpc.NewClient function does not exist in the gRPC Go API. To establish a gRPC connection, use grpc.Dial or grpc.DialContext with the appropriate options.
- grpcClient, err := grpc.NewClient(grpcConfig.Address, dialOptions...)
+ grpcClient, err := grpc.Dial(grpcConfig.Address, dialOptions...)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| grpcClient, err := grpc.NewClient(grpcConfig.Address, dialOptions...) | |
| grpcClient, err := grpc.Dial(grpcConfig.Address, dialOptions...) |
| @@ -49,7 +49,7 @@ func initFixture(t *testing.T) *fixture { | |||
| } | |||
| }() | |||
|
|
|||
| clientConn, err := grpc.Dial(listener.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
| clientConn, err := grpc.NewClient(listener.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
There was a problem hiding this comment.
Replace grpc.NewClient with grpc.Dial or grpc.DialContext and use secure credentials.
The grpc.NewClient function does not exist in the gRPC Go API. To establish a gRPC connection, use grpc.Dial or grpc.DialContext with the appropriate options. Additionally, consider using secure credentials to avoid insecure gRPC server setup.
- clientConn, err := grpc.NewClient(listener.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()))
+ clientConn, err := grpc.Dial(listener.Addr().String(), grpc.WithTransportCredentials(credentials.NewServerTLSFromFile("cert.pem", "cert.key")))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| clientConn, err := grpc.NewClient(listener.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) | |
| clientConn, err := grpc.Dial(listener.Addr().String(), grpc.WithTransportCredentials(credentials.NewServerTLSFromFile("cert.pem", "cert.key"))) |
| @@ -52,7 +52,7 @@ func (s *IntegrationTestSuite) SetupSuite() { | |||
| s.Require().NoError(err) | |||
|
|
|||
| val0 := s.network.GetValidators()[0] | |||
| s.conn, err = grpc.Dial( | |||
| s.conn, err = grpc.NewClient( | |||
There was a problem hiding this comment.
Replace grpc.NewClient with grpc.Dial or grpc.DialContext.
The grpc.NewClient function does not exist in the gRPC Go API. To establish a gRPC connection, use grpc.Dial or grpc.DialContext with the appropriate options.
- s.conn, err = grpc.NewClient(
+ s.conn, err = grpc.Dial(Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| s.conn, err = grpc.NewClient( | |
| s.conn, err = grpc.Dial( |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
* main: fix(simapp): use correct store keys for upgrade (cosmos#19987) build(ci): Remove staticmajor due to false positives (cosmos#19989) build(deps): Bump google.golang.org/grpc from 1.63.0 to 1.63.2 (cosmos#19982) chore: linting fixes (cosmos#19978) docs: reword upgrading.md (cosmos#19900)
Description
fix dependency update linting issues
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...