Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(simapp): use correct store keys for upgrade #19987

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix(simapp): use correct store keys for upgrade #19987

merged 1 commit into from
Apr 9, 2024

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Apr 9, 2024

Description

This fixes a 🐛 as the store key for accounts is not the module name. To be consistent, I have used the store keys for the other types as well

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@alpe alpe requested a review from a team as a code owner April 9, 2024 07:45
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 9, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent updates in the simapp application focus on refining the handling of store keys across various modules. Notably, the transition from using module names to store keys marks a significant change, streamlining the identification and access process for store elements. This adjustment is part of an effort to enhance clarity and efficiency within the application's architecture, particularly with the removal of the crisis module in the latest SDK version.

Changes

Files Change Summary
upgrades.go - Updated store keys for accounts, protocolpooltypes, and crisistypes modules.
- Replaced accounts.ModuleName and protocolpooltypes.ModuleName with accounts.StoreKey and protocolpooltypes.StoreKey.
- Changed crisistypes.ModuleName to crisistypes.StoreKey following the removal of the crisis module in SDK v0.51.0.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

@alpe your pull request is missing a changelog!

@alpe alpe mentioned this pull request Apr 9, 2024
Closed
12 tasks
@alpe alpe changed the title fix (simapp): use correct store keys for upgrade fix(simapp): use correct store keys for upgrade Apr 9, 2024
@julienrbrt julienrbrt added this pull request to the merge queue Apr 9, 2024
@julienrbrt julienrbrt removed this pull request from the merge queue due to a manual request Apr 9, 2024
@julienrbrt julienrbrt added this pull request to the merge queue Apr 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 9, 2024
@julienrbrt julienrbrt added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit a5d4c40 Apr 9, 2024
61 of 63 checks passed
@julienrbrt julienrbrt deleted the alex/fix_storekey branch April 9, 2024 14:02
alpe added a commit to alpe/cosmos-sdk that referenced this pull request Apr 9, 2024
@alpe
Merge branch 'main' into alex/testnet
6b71c5b 
* main:
  fix(simapp): use correct store keys for upgrade (cosmos#19987)
  build(ci): Remove staticmajor due to false positives (cosmos#19989)
  build(deps): Bump google.golang.org/grpc from 1.63.0 to 1.63.2 (cosmos#19982)
  chore: linting fixes (cosmos#19978)
  docs: reword upgrading.md (cosmos#19900)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sontrinh16 sontrinh16 sontrinh16 approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alpe @julienrbrt @sontrinh16