Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): Remove staticmajor due to false positives #19989

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Apr 9, 2024

Description

The current staticmajor version reports a false positive with cli/export.go with the resleak analyzer.
I have also tried some older versions but same or other problems occur.
As this was the only analyser active, I remove the action for now.

Example for a manual execution:

docker run -it --platform linux/x86_64 --entrypoint=sh -v=.:/src ghcr.io/orijtech/staticmajor_action@sha256:29e54e92ebf08a9bca219c03ce996c0f461cf52d01af20216d40b458e6c7339e
# cd /src ; /staticmajor -resleak -test=false ./...

False positives make it hard to trust the CI and create extra work for devs not familiar with the history of the project.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@alpe alpe requested a review from a team as a code owner April 9, 2024 09:47
@samricotta samricotta added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit 9e9cc52 Apr 9, 2024
53 checks passed
@samricotta samricotta deleted the alex/remove-staticmajor branch April 9, 2024 12:05
alpe added a commit to alpe/cosmos-sdk that referenced this pull request Apr 9, 2024
* main:
  fix(simapp): use correct store keys for upgrade (cosmos#19987)
  build(ci): Remove staticmajor due to false positives (cosmos#19989)
  build(deps): Bump google.golang.org/grpc from 1.63.0 to 1.63.2 (cosmos#19982)
  chore: linting fixes (cosmos#19978)
  docs: reword upgrading.md (cosmos#19900)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants