-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(x/genutil): fix genesis migrate
command examples
#22090
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request modify the command example string in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty for all those fixes ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
x/genutil/client/cli/migrate.go (1)
32-32
: Approved: Command example corrected.The change accurately addresses the PR objective by fixing the
genesis migrate
command example. This improvement enhances the documentation's clarity and correctness.Consider adding a comment above the
Example
field to explain the command structure, which could further improve the documentation:// Example: "<app-name> genesis migrate <target-version> <genesis-file> [flags]" Example: fmt.Sprintf("%s genesis migrate v0.47 /path/to/genesis.json --chain-id=cosmoshub-3 --genesis-time=2019-04-22T17:00:00Z", version.AppName),
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (1)
- x/genutil/client/cli/migrate.go (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
x/genutil/client/cli/migrate.go (1)
Pattern
**/*.go
: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
(cherry picked from commit 8bbf51c)
) (#22096) Co-authored-by: tutufen <tutufen@outlook.com>
(cherry picked from commit 8bbf51c)
) (#22097) Co-authored-by: tutufen <tutufen@outlook.com>
Description
Found another wrong command example:
simd genesis migrate
Summary by CodeRabbit
New Features
Bug Fixes