-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Staking REST utils refactor and querier tests (pt 1 redelegation PR) #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will put the documentation to the right folder for website deployment.
Greg/docs deployment
Hotfix: double curlies breaks vuepress - single curlies does not
…edekunze/2182-redelegation-endpoint Pull
HOTFIX: add temporary file to sync build with website (RPC)
…edekunze/2182-redelegation-endpoint Pull
….com/cosmos/cosmos-sdk into fedekunze/staking-rest-utils-refactor Pull
fedekunze
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
October 19, 2018 19:51
fedekunze
changed the title
WIP: Staking rest utils refactor(pt 1 redelegation PR)
R4R: Staking REST utils refactor(pt 1 redelegation PR)
Oct 19, 2018
fedekunze
changed the title
R4R: Staking REST utils refactor(pt 1 redelegation PR)
R4R: Staking REST utils refactor and querier tests (pt 1 redelegation PR)
Oct 19, 2018
Codecov Report
@@ Coverage Diff @@
## develop #2537 +/- ##
===========================================
+ Coverage 60.04% 60.28% +0.24%
===========================================
Files 150 150
Lines 8589 8589
===========================================
+ Hits 5157 5178 +21
+ Misses 3083 3067 -16
+ Partials 349 344 -5 |
5 tasks
cwgoes
approved these changes
Oct 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, thanks @fedekunze
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split part 1 from #2336
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #reviewed
Files changed
in the github PR explorerFor Admin Use: