Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Staking REST utils refactor and querier tests (pt 1 redelegation PR) #2537

Merged
merged 33 commits into from
Oct 19, 2018

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Oct 19, 2018

Split part 1 from #2336


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

zramsay and others added 30 commits August 29, 2018 15:37
This change will put the documentation to the right folder for website deployment.
Hotfix: double curlies breaks vuepress - single curlies does not
HOTFIX: add temporary file to sync build with website (RPC)
@fedekunze fedekunze changed the title WIP: Staking rest utils refactor(pt 1 redelegation PR) R4R: Staking REST utils refactor(pt 1 redelegation PR) Oct 19, 2018
@fedekunze fedekunze changed the title R4R: Staking REST utils refactor(pt 1 redelegation PR) R4R: Staking REST utils refactor and querier tests (pt 1 redelegation PR) Oct 19, 2018
@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #2537 into develop will increase coverage by 0.24%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2537      +/-   ##
===========================================
+ Coverage    60.04%   60.28%   +0.24%     
===========================================
  Files          150      150              
  Lines         8589     8589              
===========================================
+ Hits          5157     5178      +21     
+ Misses        3083     3067      -16     
+ Partials       349      344       -5

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks @fedekunze

@cwgoes cwgoes merged commit 57277d1 into develop Oct 19, 2018
@cwgoes cwgoes deleted the fedekunze/staking-rest-utils-refactor branch October 19, 2018 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants