v0.38.4-RC1

[alexanderbez]

closes: #6006

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

[codecov]

Codecov Report

Merging #6249 into rc1/v0.38.4 will decrease coverage by 2.97%.
The diff coverage is 37.50%.

@@               Coverage Diff               @@
##           rc1/v0.38.4    #6249      +/-   ##
===============================================
- Coverage        54.37%   51.39%   -2.98%     
===============================================
  Files              313      336      +23     
  Lines            19035    20551    +1516     
===============================================
+ Hits             10350    10563     +213     
- Misses            7888     9185    +1297     
- Partials           797      803       +6     

[tac0turtle]

Do you want to pull in the github action changes so we can run long sims here?

[alexanderbez]

@marbar3778 add it to the meta-issue.

[tac0turtle]

how long do the long sims usually run? it was run for 6 hours here, is that in line with before

[alexanderbez]

how long do the long sims usually run? it was run for 6 hours here, is that in line with before

Depends on the infra. Back when we had dedicated AWS machines that we used via a slackbot, a few hours. Via Github Actions, no clue...

[tac0turtle]

hmm github only allows 6 hours for an action, we may have to think of a way around this.

[fedekunze]

is this the only entry we need to add?

[alexanderbez]

Yes -- see #6006. There were only two PRs added to this release.

[alexanderbez]

hmm github only allows 6 hours for an action, we may have to think of a way around this.

We can either pay for infra or we can bump down the number of seeds/blocks we execute.

[tac0turtle]

was the number of seeds/blocks chosen arbitrarily? we can reduce and split the seeds across two jobs

[alexanderbez]

TBH, I don't recall how the long multi-seed sim works. Take a look at the Makefile target and see what it does. I'm pretty sure we just execute a bash script with a pre-configured set of seeds.

[alexanderbez]

That being said, we can still release here and look into this separately.

[alessio]

https://github.com/cosmos/tools/blob/master/cmd/runsim/main.go#L32 - that's the default list that can be overridden by a comma-separated list of seeds passed via the -Seeds flag. For more info, please see runsim -h.

[alessio]

Please remember to use git tag -a :)