-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temp Up and Temp Down Commands is not working #668
Comments
I'm not 100% sure what you are describing so, apologies if I get it wrong. i.e. How do you know the commands are not executing/producing the desired change on the A/C? Looking at those codes etc, they look like they are a result of you pressing the "temp up" and "temp down" buttons on the remote. i don't own the make/model of the A/C so I can't say for certain, but I think the code is reporting what button was last pressed AND then setting the rest of the state of the A/C to what is in the message. etc. e.g. Another way to control the devices is via the class method. See https://github.com/markszabo/IRremoteESP8266/blob/master/test/ir_Haier_test.cpp#L356 for some examples. You can adapt some of the other existing A/C examples to suit. Just be aware you need to use the
|
What if I have to increase the temp by one degree and down by one degree ?? Can I use IRHaierAC ac(kIrPin); for increasing ac.setcommand(kHaierAcCmdTempUp); for decreasing is it the right way to increase and decrease temperature by 1 degree by using class method??. |
No. I believe the correct way would be:
Now, I'm not sure if that works perfectly etc with the A/C Unit, as I don't have one to test against. Almost all A/C remotes send the entire configuration in each message. i.e. The entire state of the remote control. Not "just change one little aspect please". |
Hello, how can resolve this??? |
Haier A/C is a weird one it seems. It doesn't have Try the following:
Let us know how that goes please. |
Yes it is working by ac.setCommand(kHaierAcCmdOn);
|
@mazeemsk I've added a test case to try to emulate what you are doing. See the commit 9d189fd As far as I can tell, the code is doing what you're trying to do. The net result is the unit will stay at 25C. Each send, the command appears to be valid and do the correct things. See the If you believe it isn't, in order for me to fix it I'll need you to please capture (via Then press Temp Up: Please provide the Also, you might as well include a link (or paste) the entire code you are using so we can see if there might be some other problem. |
Okay I tried to send the commands via MQTT but the results are same the complete code I am using is
The Results are:
sorry for my bad English. |
Can you please do the above, I'm guessing we got something wrong on how to emulate it. |
Here it is...
and Temp UP
|
* Add hidden state information to HaierAC's initial state based on real world data. * Add/adjust unit tests to catch this. Should fix #668
Thanks for that @mazeemsk It was really helpful. Can you please download and try the code in this branch: https://github.com/markszabo/IRremoteESP8266/tree/Issue668 PR #671 should fix it. Let me know if it does or doesn't. |
@mazeemsk Have you had any luck or a chance to test it? |
@crankyoldgit Its working now as expected.....Will you please explain in a simple way what was the issue?? for my understanding if such cases occurs in future. |
The crux of the issue was there was some missing data in the initial data/state that the class constructed. When I added that we were able to construct me the exact messages you captured. Your captures helped find that missing data. |
_v2.6.0 (20190430)_ **[Bug Fixes]** - Fixed problem where LG protocol used wrong duty cycle for repeat. (#687) - Fix checksum calculation for Daikin protocols. (#678) - Fix the byte array version of sendGree() (#684, #685) - Fix artificial vs. real state creation on HaierAC. (#668, #671) - Fix issues caused by having `MQTT_ENABLE` set to false. (#677) - Fix compile problem when DEBUG is defined. (#673, #674) - Fix Minor bug with MQTT_ENABLE False condition (#654) **[Features]** - Experimental support for DAIKIN216 (ARC433B69) (#690) - Experimental support for Mitsubishi Heavy Industries A/Cs. (#660, #665, #667) - Support more features of TCL A/C (#656) - Add LEGO(TM) Power Functions IR protocol. (#655) - Add Panasonic AC RKR model & Example (#649) - DAIKIN/IRDaikinESP overhaul and add Comfort mode support. (#678) **WARNING**: Previous `sendDaikin()` calls may not work. Please recapture codes or use `kDaikinStateLengthShort` for `nbytes` in those calls. - IRMQTTServer: Move MQTT server and other parameters to WifiManager. (#680) **WARNING**: Previous users may need to fully wipe/reset the SPIFFS/WifiManager settings by visiting `http://<your_esp8266's_ip_address>/reset` prior to or after update. - Add Wifi filtering options to IRMQTTServer. (#679) - Add advanced aircon/climate functionality to IRMQTTServer (#677) - Initial prototype of a common interface for all A/Cs. (#664) - Improve MQTT topic usage for feedback messages. (#663) - Add multiple independent GPIO sending support via MQTT. (#661) **[Misc]** - Adjust kGreeHdrSpace to 4500 (#684, #686) - Add Home Assistant mqtt climate instructions. (#682) - Implement htmlEscape() to prevent XSS etc. (#681) - Add F() Macros (#670) - Update Daikin2's Cool mode min temp to 18C (#658) - Change per byte bit-order in Electra protocol. (#648) - Improve Daikin2 power on/off. (#647)
_v2.6.0 (20190430)_ **[Bug Fixes]** - Fixed problem where LG protocol used wrong duty cycle for repeat. (#687) - Fix checksum calculation for Daikin protocols. (#678) - Fix the byte array version of sendGree() (#684, #685) - Fix artificial vs. real state creation on HaierAC. (#668, #671) - Fix issues caused by having `MQTT_ENABLE` set to false. (#677) - Fix compile problem when DEBUG is defined. (#673, #674) - Fix Minor bug with MQTT_ENABLE False condition (#654) **[Features]** - Experimental support for DAIKIN216 (ARC433B69) (#690) - Experimental support for Mitsubishi Heavy Industries A/Cs. (#660, #665, #667) - Support more features of TCL A/C (#656) - Add LEGO(TM) Power Functions IR protocol. (#655) - Add Panasonic AC RKR model & Example (#649) - DAIKIN/IRDaikinESP overhaul and add Comfort mode support. (#678) **WARNING**: Previous `sendDaikin()` calls may not work. Please recapture codes or use `kDaikinStateLengthShort` for `nbytes` in those calls. - IRMQTTServer: Move MQTT server and other parameters to WifiManager. (#680) **WARNING**: Previous users may need to fully wipe/reset the SPIFFS/WifiManager settings by visiting `http://<your_esp8266's_ip_address>/reset` prior to or after update. - Add Wifi filtering options to IRMQTTServer. (#679) - Add advanced aircon/climate functionality to IRMQTTServer (#677) - Initial prototype of a common interface for all A/Cs. (#664) - Improve MQTT topic usage for feedback messages. (#663) - Add multiple independent GPIO sending support via MQTT. (#661) **[Misc]** - Adjust kGreeHdrSpace to 4500 (#684, #686) - Add Home Assistant mqtt climate instructions. (#682) - Implement htmlEscape() to prevent XSS etc. (#681) - Add F() Macros (#670) - Update Daikin2's Cool mode min temp to 18C (#658) - Change per byte bit-order in Electra protocol. (#648) - Improve Daikin2 power on/off. (#647)
FYI, this has been included in the newly released v2.6.0 of the library. |
Downloaded Thanks David...
…On Tue, Apr 30, 2019 at 6:59 PM David Conran ***@***.***> wrote:
FYI, this has been included in the newly released v2.6.0 of the library.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#668 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALNYCPYVZIE5U5Y4AKGYVO3PTBGDFANCNFSM4HEY2VFA>
.
--
--------------------------------------------------------------------------------------------------------------------------------------------------
M. Azeem Sheikh
Contact:- 03457847189, 03045806570
Email: m.azeem.sk@gmail.com
|
- Convert captured IR A/C messages and update the internal/MQTT climate state. - Supports all "common" supported A/C messages. * Note: Argo and Trotec don't currently have decoders so will not work in practice. - Relevant unit tests. - Update numerous A/C classes/protocols to current code standards. - Major rework/breaking change to Argo A/C support. - **[BUG]** Fixed a bug with setMode()/getMode() for HAIER_AC. - Update Denon to use the proper constant name style. - Add #define switches _IRMQTTServer_ to control new functionality: * USE_DECODED_AC_SETTINGS: Whether we use the new functionality or not * IGNORE_DECODED_AC_PROTOCOL: Allow other A/C remotes to control non-same A/Cs * REPLAY_DECODED_AC_MESSAGE: Do we replay the decoded A/C message or not Tested on a Nodemcu board with a Kelvinator A/C remote. Appears to work as expected. For #702 FYI #668
FYI, The changes mentioned above have been include in v2.6.1 of this library, which has just been released. |
Hi,
I am trying to send temp_up and temp_down commands but its is not working.....I got the code using IRrecvDumpV2 for temp up is
18:00:47.022 -> Encoding : HAIER_AC
18:00:47.022 -> Code : A51666180C802000E5 (72 bits)
18:00:47.022 -> Mesg Desc.: Command: 6 (Temp Up), Mode: 0 (AUTO), Temp: 17C, Fan: 0 (AUTO), Swing: 1 (Up), Sleep: Off, Health: Off, Current Time: 6:24, On Timer: Off, Off Timer: Off
18:00:47.055 -> Library : v2.5.5
18:00:47.055 ->
18:00:47.055 -> Raw Timing[149]:
18:00:47.055 -> + 3076, - 2998, + 3076, - 4244, + 640, - 1648, + 594, - 542,
18:00:47.055 -> + 592, - 1664, + 592, - 674, + 592, - 540, + 592, - 1666,
18:00:47.089 -> + 592, - 540, + 592, - 1794, + 594, - 540, + 620, - 510,
18:00:47.089 -> + 610, - 540, + 594, - 1776, + 610, - 544, + 592, - 1646,
18:00:47.089 -> + 610, - 1648, + 610, - 672, + 590, - 526, + 610, - 1662,
18:00:47.089 -> + 620, - 1652, + 590, - 670, + 596, - 540, + 592, - 1662,
18:00:47.123 -> + 594, - 1646, + 610, - 674, + 590, - 540, + 594, - 540,
18:00:47.123 -> + 594, - 542, + 618, - 1764, + 610, - 1646, + 610, - 540,
18:00:47.123 -> + 594, - 538, + 594, - 672, + 592, - 538, + 594, - 540,
18:00:47.123 -> + 594, - 546, + 588, - 670, + 620, - 1632, + 610, - 1662,
18:00:47.123 -> + 594, - 540, + 592, - 670, + 596, - 1662, + 594, - 540,
18:00:47.157 -> + 592, - 540, + 596, - 668, + 594, - 538, + 622, - 524,
18:00:47.157 -> + 594, - 538, + 596, - 668, + 596, - 540, + 592, - 542,
18:00:47.157 -> + 590, - 1662, + 594, - 672, + 594, - 538, + 596, - 538,
18:00:47.157 -> + 590, - 554, + 596, - 668, + 596, - 536, + 598, - 538,
18:00:47.191 -> + 596, - 538, + 596, - 670, + 594, - 538, + 594, - 540,
18:00:47.191 -> + 594, - 538, + 620, - 686, + 592, - 1646, + 610, - 1646,
18:00:47.191 -> + 612, - 1646, + 610, - 698, + 590, - 540, + 594, - 1662,
18:00:47.191 -> + 596, - 540, + 594, - 1660, + 622
18:00:47.191 ->
18:00:47.225 -> uint16_t rawData[149] = {3076, 2998, 3076, 4244, 640, 1648, 594, 542, 592, 1664, 592, 674, 592, 540, 592, 1666, 592, 540, 592, 1794, 594, 540, 620, 510, 610, 540, 594, 1776, 610, 544, 592, 1646, 610, 1648, 610, 672, 590, 526, 610, 1662, 620, 1652, 590, 670, 596, 540, 592, 1662, 594, 1646, 610, 674, 590, 540, 594, 540, 594, 542, 618, 1764, 610, 1646, 610, 540, 594, 538, 594, 672, 592, 538, 594, 540, 594, 546, 588, 670, 620, 1632, 610, 1662, 594, 540, 592, 670, 596, 1662, 594, 540, 592, 540, 596, 668, 594, 538, 622, 524, 594, 538, 596, 668, 596, 540, 592, 542, 590, 1662, 594, 672, 594, 538, 596, 538, 590, 554, 596, 668, 596, 536, 598, 538, 596, 538, 596, 670, 594, 538, 594, 540, 594, 538, 620, 686, 592, 1646, 610, 1646, 612, 1646, 610, 698, 590, 540, 594, 1662, 596, 540, 594, 1660, 622}; // HAIER_AC
18:00:47.293 -> uint8_t state[9] = {0xA5, 0x16, 0x66, 0x18, 0x0C, 0x80, 0x20, 0x00, 0xE5};
and for temp down is
18:00:04.059 -> Encoding : HAIER_AC
18:00:04.059 -> Code : A50766180C802000D6 (72 bits)
18:00:04.059 -> Mesg Desc.: Command: 7 (Temp Down), Mode: 0 (AUTO), Temp: 16C, Fan: 0 (AUTO), Swing: 1 (Up), Sleep: Off, Health: Off, Current Time: 6:24, On Timer: Off, Off Timer: Off
18:00:04.092 -> Library : v2.5.5
18:00:04.092 ->
18:00:04.092 -> Raw Timing[149]:
18:00:04.092 -> + 3078, - 3000, + 3074, - 4264, + 592, - 1676, + 570, - 564,
18:00:04.092 -> + 596, - 1662, + 568, - 698, + 594, - 536, + 596, - 1662,
18:00:04.126 -> + 568, - 566, + 566, - 1826, + 562, - 566, + 594, - 590,
18:00:04.126 -> + 528, - 568, + 566, - 696, + 570, - 564, + 568, - 1690,
18:00:04.126 -> + 566, - 1688, + 568, - 1892, + 494, - 570, + 564, - 1692,
18:00:04.126 -> + 590, - 1678, + 566, - 698, + 568, - 568, + 566, - 1688,
18:00:04.159 -> + 568, - 1688, + 568, - 700, + 566, - 568, + 566, - 564,
18:00:04.159 -> + 568, - 564, + 596, - 1810, + 566, - 1686, + 570, - 564,
18:00:04.159 -> + 570, - 566, + 566, - 744, + 520, - 566, + 566, - 566,
18:00:04.159 -> + 568, - 568, + 562, - 698, + 594, - 1676, + 566, - 1686,
18:00:04.159 -> + 570, - 566, + 568, - 696, + 566, - 1688, + 570, - 566,
18:00:04.194 -> + 568, - 568, + 564, - 700, + 564, - 564, + 596, - 548,
18:00:04.194 -> + 572, - 564, + 570, - 696, + 568, - 566, + 568, - 566,
18:00:04.194 -> + 570, - 1684, + 570, - 696, + 568, - 566, + 566, - 566,
18:00:04.194 -> + 594, - 552, + 566, - 696, + 568, - 566, + 566, - 566,
18:00:04.227 -> + 568, - 566, + 564, - 700, + 566, - 564, + 568, - 568,
18:00:04.227 -> + 564, - 570, + 592, - 706, + 570, - 1688, + 568, - 1686,
18:00:04.227 -> + 568, - 568, + 566, - 1844, + 568, - 566, + 568, - 1692,
18:00:04.227 -> + 564, - 1692, + 564, - 566, + 596
18:00:04.227 ->
18:00:04.262 -> uint16_t rawData[149] = {3078, 3000, 3074, 4264, 592, 1676, 570, 564, 596, 1662, 568, 698, 594, 536, 596, 1662, 568, 566, 566, 1826, 562, 566, 594, 590, 528, 568, 566, 696, 570, 564, 568, 1690, 566, 1688, 568, 1892, 494, 570, 564, 1692, 590, 1678, 566, 698, 568, 568, 566, 1688, 568, 1688, 568, 700, 566, 568, 566, 564, 568, 564, 596, 1810, 566, 1686, 570, 564, 570, 566, 566, 744, 520, 566, 566, 566, 568, 568, 562, 698, 594, 1676, 566, 1686, 570, 566, 568, 696, 566, 1688, 570, 566, 568, 568, 564, 700, 564, 564, 596, 548, 572, 564, 570, 696, 568, 566, 568, 566, 570, 1684, 570, 696, 568, 566, 566, 566, 594, 552, 566, 696, 568, 566, 566, 566, 568, 566, 564, 700, 566, 564, 568, 568, 564, 570, 592, 706, 570, 1688, 568, 1686, 568, 568, 566, 1844, 568, 566, 568, 1692, 564, 1692, 564, 566, 596}; // HAIER_AC
18:00:04.330 -> uint8_t state[9] = {0xA5, 0x07, 0x66, 0x18, 0x0C, 0x80, 0x20, 0x00, 0xD6};
and I am trying to send is as
#include <IRsend.h>
#include <ir_Haier.h>
const uint16_t kIrLed = 4;
IRsend ac(kIrLed);
uint8_t temp_up[9] = {0xA5, 0x16, 0x66, 0x18, 0x0C, 0x80, 0x20, 0x00, 0xE5};
uint8_t temp_down[9] = {0xA5, 0x07, 0x66, 0x18, 0x0C, 0x80, 0x20, 0x00, 0xD6};
ac.sendHaierAC(temp_down);
ac.sendHaierAC(temp_up);
its just produce beeps but command not executed....but by same procedure i can send ON/OFF commands and it is working flawlessly. where am I missing??? please guide.
The text was updated successfully, but these errors were encountered: