Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error with compile flag DEBUG at ESP8266 (Arduino) #673

Closed
timostr opened this issue Apr 16, 2019 · 2 comments · Fixed by #674
Closed

Compile error with compile flag DEBUG at ESP8266 (Arduino) #673

timostr opened this issue Apr 16, 2019 · 2 comments · Fixed by #674
Assignees
@crankyoldgit
Labels
bug

Comments

@timostr
Copy link

timostr commented Apr 16, 2019

Version/revison of the library used

v2.5.6

Expected behavior

Enabling -DDEBUG at Arduino should allow compile without errors

Actual behavior

Compile error: more than one instance of overloaded function "HardwareSerial::println" matches the argument list: -- function "Print::println(char)" -- function "Print::println(unsigned char, int = 10)" -- function "Print::println(int, int = 10)" -- function "Print::println(unsigned int, int = 10)" -- function "Print::println(long, int = 10)" -- function "Print::println(unsigned long, int = 10)" -- function "Print::println(double, int = 2)" -- argument types are: (uint64_t) -- object type is: HardwareSerial
Correction: R132: ir_MWM.cpp change DPRINTLN(data); --> DPRINTLN((uint8) data & 0xFF);

What steps did you do, and what did or didn't actually happen?

  1. Compile with -DDEBUG using esp8266 (Arduino)

Steps to reproduce the behavior

What can we do to (pref. reliably) repeat what is happening?
Simple compile with -DDEBUG with Arduino (ESP8266)

I have followed the steps in the Troubleshooting Guide & read the FAQ

_Yes

Has this library/code previously worked as expected for you?

_Yes - not sure must be version from last year
crankyoldgit added a commit that referenced this issue Apr 16, 2019
@crankyoldgit
Fix compile problem when DEBUG is defined.
7efb83a 
Fixes #673
@crankyoldgit crankyoldgit mentioned this issue Apr 16, 2019
Merged
@crankyoldgit
Copy link
Owner

Thanks for the report. Sadly it didn't show under my linux-based unit-tests. But yes, when compiled fully under the Arduino compilers it does berk.

#674 should fix it.

@crankyoldgit crankyoldgit self-assigned this Apr 16, 2019
crankyoldgit added a commit that referenced this issue Apr 16, 2019
@crankyoldgit
Fix compile problem when DEBUG is defined. (#674)
cb524ad 
Fixes #673
crankyoldgit added a commit that referenced this issue Apr 30, 2019
@crankyoldgit
v2.6.0 release
19468bc 
_v2.6.0 (20190430)_

**[Bug Fixes]**
- Fixed problem where LG protocol used wrong duty cycle for repeat. (#687)
- Fix checksum calculation for Daikin protocols. (#678)
- Fix the byte array version of sendGree() (#684, #685)
- Fix artificial vs. real state creation on HaierAC. (#668, #671)
- Fix issues caused by having `MQTT_ENABLE` set to false. (#677)
- Fix compile problem when DEBUG is defined. (#673, #674)
- Fix Minor bug with MQTT_ENABLE False condition (#654)

**[Features]**
- Experimental support for DAIKIN216 (ARC433B69) (#690)
- Experimental support for Mitsubishi Heavy Industries A/Cs. (#660, #665, #667)
- Support more features of TCL A/C (#656)
- Add LEGO(TM) Power Functions IR protocol. (#655)
- Add Panasonic AC RKR model & Example (#649)
- DAIKIN/IRDaikinESP overhaul and add Comfort mode support. (#678)
  **WARNING**: Previous `sendDaikin()` calls may not work.
               Please recapture codes or use `kDaikinStateLengthShort` for
               `nbytes` in those calls.
- IRMQTTServer: Move MQTT server and other parameters to WifiManager. (#680)
  **WARNING**: Previous users may need to fully wipe/reset the
               SPIFFS/WifiManager settings by visiting
               `http://<your_esp8266's_ip_address>/reset` prior to or
               after update.
- Add Wifi filtering options to IRMQTTServer. (#679)
- Add advanced aircon/climate functionality to IRMQTTServer (#677)
- Initial prototype of a common interface for all A/Cs. (#664)
- Improve MQTT topic usage for feedback messages. (#663)
- Add multiple independent GPIO sending support via MQTT. (#661)

**[Misc]**
- Adjust kGreeHdrSpace to 4500 (#684, #686)
- Add Home Assistant mqtt climate instructions. (#682)
- Implement htmlEscape() to prevent XSS etc. (#681)
- Add F() Macros (#670)
- Update Daikin2's Cool mode min temp to 18C (#658)
- Change per byte bit-order in Electra protocol. (#648)
- Improve Daikin2 power on/off. (#647)
@crankyoldgit crankyoldgit mentioned this issue Apr 30, 2019
Merged
crankyoldgit added a commit that referenced this issue Apr 30, 2019
@crankyoldgit
v2.6.0 release (#692)
528849e 
_v2.6.0 (20190430)_

**[Bug Fixes]**
- Fixed problem where LG protocol used wrong duty cycle for repeat. (#687)
- Fix checksum calculation for Daikin protocols. (#678)
- Fix the byte array version of sendGree() (#684, #685)
- Fix artificial vs. real state creation on HaierAC. (#668, #671)
- Fix issues caused by having `MQTT_ENABLE` set to false. (#677)
- Fix compile problem when DEBUG is defined. (#673, #674)
- Fix Minor bug with MQTT_ENABLE False condition (#654)

**[Features]**
- Experimental support for DAIKIN216 (ARC433B69) (#690)
- Experimental support for Mitsubishi Heavy Industries A/Cs. (#660, #665, #667)
- Support more features of TCL A/C (#656)
- Add LEGO(TM) Power Functions IR protocol. (#655)
- Add Panasonic AC RKR model & Example (#649)
- DAIKIN/IRDaikinESP overhaul and add Comfort mode support. (#678)
  **WARNING**: Previous `sendDaikin()` calls may not work.
               Please recapture codes or use `kDaikinStateLengthShort` for
               `nbytes` in those calls.
- IRMQTTServer: Move MQTT server and other parameters to WifiManager. (#680)
  **WARNING**: Previous users may need to fully wipe/reset the
               SPIFFS/WifiManager settings by visiting
               `http://<your_esp8266's_ip_address>/reset` prior to or
               after update.
- Add Wifi filtering options to IRMQTTServer. (#679)
- Add advanced aircon/climate functionality to IRMQTTServer (#677)
- Initial prototype of a common interface for all A/Cs. (#664)
- Improve MQTT topic usage for feedback messages. (#663)
- Add multiple independent GPIO sending support via MQTT. (#661)

**[Misc]**
- Adjust kGreeHdrSpace to 4500 (#684, #686)
- Add Home Assistant mqtt climate instructions. (#682)
- Implement htmlEscape() to prevent XSS etc. (#681)
- Add F() Macros (#670)
- Update Daikin2's Cool mode min temp to 18C (#658)
- Change per byte bit-order in Electra protocol. (#648)
- Improve Daikin2 power on/off. (#647)
@crankyoldgit
Copy link
Owner

FYI, this has been included in the newly released v2.6.0 of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crankyoldgit crankyoldgit

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compile problem when DEBUG is defined. crankyoldgit/IRremoteESP8266
2 participants
@timostr @crankyoldgit