Add F() Macros

[jimmys01]

No description provided.

[crankyoldgit]

Thanks for the changes. That's a lot of effort. :)
You've use String() calls when I think you don't need to. They are to be avoided as they are probably unneeded and they require special handling to allow the code to compile outside of the Arduino Framework. e.g. Unit tests and tools etc. use standard gcc/g++ etc on Linux etc.

[crankyoldgit]

Travis found at least one compilation error:

../src/ir_Daikin.cpp: In member function ‘std::string IRDaikin2::toString()’:
../src/ir_Daikin.cpp:1263:35: error: ‘String’ was not declared in this scope
   result += String(", Swing (H): ") + uint64ToString(getSwingHorizontal());

and a pile-of-lint issues:

$ python cpplint.py --extensions=c,cc,cpp,ino --headers=h,hpp {src,test,tools}/*.{h,c,cc,cpp,hpp,ino} examples/*/*.{h,c,cc,cpp,hpp,ino}

src/ir_Coolix.cpp:378:  Extra space after ( in function call  [whitespace/parens] [4]
src/ir_Daikin.cpp:463:  Extra space after ( in function call  [whitespace/parens] [4]
src/ir_Daikin.cpp:1231:  Extra space after ( in function call  [whitespace/parens] [4]
src/ir_Daikin.cpp:1289:  Tab found; better to use spaces  [whitespace/tab] [1]
src/ir_Daikin.cpp:1330:  Extra space before last semicolon. If this should be an empty statement, use {} instead.  [whitespace/semicolon] [5]
src/ir_Daikin.cpp:1338:  Extra space before last semicolon. If this should be an empty statement, use {} instead.  [whitespace/semicolon] [5]
src/ir_Gree.cpp:379:  Tab found; better to use spaces  [whitespace/tab] [1]
src/ir_Hitachi.cpp:271:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
src/ir_Panasonic.cpp:691:  Extra space after ( in function call  [whitespace/parens] [4]
src/ir_Tcl.cpp:313:  Extra space before last semicolon. If this should be an empty statement, use {} instead.  [whitespace/semicolon] [5]
src/IRutils.cpp:377:  Tab found; better to use spaces  [whitespace/tab] [1]
src/IRutils.cpp:393:  Tab found; better to use spaces  [whitespace/tab] [1]
src/IRutils.cpp:394:  Tab found; better to use spaces  [whitespace/tab] [1]
src/IRutils.cpp:396:  Tab found; better to use spaces  [whitespace/tab] [1]
src/IRutils.cpp:397:  Tab found; better to use spaces  [whitespace/tab] [1]
src/IRutils.cpp:401:  Tab found; better to use spaces  [whitespace/tab] [1]
src/IRutils.cpp:402:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 17

which need to be fixed.

[jimmys01]

Time is up for today, thank you for your guidance

[crankyoldgit]

Time is up for today, thank you for your guidance

You've done well so far. That's a lot of effort in those commits. :-)

[crankyoldgit]

Only a few linter issues to go:

src/ir_Coolix.cpp:378:  Extra space after ( in function call  [whitespace/parens] [4]
src/ir_Daikin.cpp:463:  Extra space after ( in function call  [whitespace/parens] [4]
src/ir_Daikin.cpp:1231:  Extra space after ( in function call  [whitespace/parens] [4]
src/ir_Daikin.cpp:1331:  Extra space before last semicolon. If this should be an empty statement, use {} instead.  [whitespace/semicolon] [5]
src/ir_Daikin.cpp:1339:  Extra space before last semicolon. If this should be an empty statement, use {} instead.  [whitespace/semicolon] [5]
src/ir_Panasonic.cpp:691:  Extra space after ( in function call  [whitespace/parens] [4]

These two I suspect are incorrect indentation levels. or when you refactored a single line into multiple ones.

src/ir_Daikin.cpp:1288:  If/else bodies with multiple statements require braces  [readability/braces] [4]
src/ir_Gree.cpp:377:  If/else bodies with multiple statements require braces  [readability/braces] [4]

The unit tests now can run though and have detected a number of errors. I'll re-review and try to find what problems have been introduced.

[crankyoldgit]

A few bugs and typos were introduced that need to be fixed before merge.
Other than those and the few remaining lint issues, it's looking great!