Make A/C example code a bit more simple. #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
crankyoldgit
commented
Nov 17, 2018
crankyoldgit
commented
- Use a common variable name for the AC object in all examples.
- Convert UPPER_CASE to kConstant in examples.
- Use .toString() instead of adhoc .getBlah() calls.
- Use a common variable name for the AC object in all examples. - Convert UPPER_CASE to kConstant in examples. - Use .toString() instead of adhoc .getBlah() calls.
crankyoldgit
force-pushed
the
ac-examples-cleanup
branch
from
f279830 to
56f64d8
Compare
markszabo
approved these changes
Nov 17, 2018
crankyoldgit
added a commit
that referenced
this pull request
Nov 23, 2018
**[Features]** - Add deep support for the Hitachi 28-Byte A/C Protocol (#563) - Deep decoding for Whirlpool A/C (#572) - Improve security options for IRMQTTServer example. (#575) - Require a changed firmware password before upload. (#576) **[Misc]** - Add missing '}' in output of Auto analyse. (#562) - Make A/C example code a bit more simple. (#571)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Nov 23, 2018
**[Features]** - Add deep support for the Hitachi 28-Byte A/C Protocol (#563) - Deep decoding for Whirlpool A/C (#572) - Improve security options for IRMQTTServer example. (#575) - Require a changed firmware password before upload. (#576) **[Misc]** - Add missing `}` in output of Auto analyse. (#562) - Make A/C example code a bit more simple. (#571)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.