Require a changed firmware password before upload. #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require that the user changes the default HTTP password before we allow
OTA firmware upload.
- Remove 'FIRMWARE_OTA_PASSWORD_ENABLE'. It's now always on.
- Rework user settings so it's more obvious where and what they can change.
- Add option to ignore 'UNKNOWN' IR messages that are received via IR.
- Warn the user if they have enabled OTA updates, but not changed the password.
- Other minor cleanups.
- Fix issue with DEBUG. i.e. incorrectly used `#ifdef` instead of `#if`
Tested: FIRMWARE_OTA, REPORT_UNKNOWNS, & changed/unchanged default password
on a D1 Mini, and a Nodemcu device.
Ref: #574 #575
markszabo
approved these changes
Nov 23, 2018
crankyoldgit
added a commit
that referenced
this pull request
Nov 23, 2018
**[Features]** - Add deep support for the Hitachi 28-Byte A/C Protocol (#563) - Deep decoding for Whirlpool A/C (#572) - Improve security options for IRMQTTServer example. (#575) - Require a changed firmware password before upload. (#576) **[Misc]** - Add missing '}' in output of Auto analyse. (#562) - Make A/C example code a bit more simple. (#571)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Nov 23, 2018
**[Features]** - Add deep support for the Hitachi 28-Byte A/C Protocol (#563) - Deep decoding for Whirlpool A/C (#572) - Improve security options for IRMQTTServer example. (#575) - Require a changed firmware password before upload. (#576) **[Misc]** - Add missing `}` in output of Auto analyse. (#562) - Make A/C example code a bit more simple. (#571)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require that the user changes the default HTTP password before we allow OTA firmware upload.
FIRMWARE_OTA_PASSWORD_ENABLE. It's now always on.UNKNOWNIR messages that are received via IR.DEBUG. i.e. incorrectly used#ifdefinstead of#ifTested:
FIRMWARE_OTA,REPORT_UNKNOWNS, & changed vs. unchanged default passwordon a D1 Mini, and a Nodemcu device.
Ref: #574 #575