Deep decoding for Whirlpool A/C #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial check in of some code to support deep decoding of Whirlpool A/C * Checksum support added to decodeWhirlpoolAC() * Some basic untested support for: - Mode - Fan speed - Temp Unit tests to come later. Ref: #509
Also include unit tests for functions added thus far.
inc. Unit tests.
- On & Off timer support - Refactor Clock routines. - Add set/getPowerToggle(). - Clean up some incorrect bit ordering for some routines. - Unit test coverage for new stuff and more real examples.
Automatically set the Command/Button press when changing other modes.
I was off by a nibble. Fixed.
I was off by a nibble.
- Add tests for PowerToggles - Add real-data check for fan speed reading.
- set/getModel() - Handle the changing min temp. - Unit tests for the above.
- Add model info for DG11J1-91 remote - Handle max temp correctly for DG11J1-91
- Set fan to auto - Seems to set temp to 23C.
- Add comments noting what modes are not implemented etc. - Unit tests for sleep and super modes.
- Correct the initial/reset state for WhirlpoolAc - Unit tests to verify we can construct a valid WhirlpoolAc message when compared to a real example.
crankyoldgit
added a commit
that referenced
this pull request
Nov 23, 2018
**[Features]** - Add deep support for the Hitachi 28-Byte A/C Protocol (#563) - Deep decoding for Whirlpool A/C (#572) - Improve security options for IRMQTTServer example. (#575) - Require a changed firmware password before upload. (#576) **[Misc]** - Add missing '}' in output of Auto analyse. (#562) - Make A/C example code a bit more simple. (#571)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Nov 23, 2018
**[Features]** - Add deep support for the Hitachi 28-Byte A/C Protocol (#563) - Deep decoding for Whirlpool A/C (#572) - Improve security options for IRMQTTServer example. (#575) - Require a changed firmware password before upload. (#576) **[Misc]** - Add missing `}` in output of Auto analyse. (#562) - Make A/C example code a bit more simple. (#571)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support deep decoding and creation of Whirlpool A/C messages
Supports two different models.
Unit test coverage for all supported modes/settings.
Modes fully supported:
Partial Support:
Not supported:
Help from @josh929800 @raducostea @redmusicxd
Fixes #509