[BUG] Ensure IRrecv's GPIO is set to input mode.
#774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crankyoldgit
requested review from
sillyfrog,
rahuljawale,
darshkpatel and
markszabo
|
PR has been confirmed to fix the issue. See #768 (comment) |
* Testing on different ESP32 boards highlighted that unlike ESP8266's the GPIO needs to be explicitly set to INPUT (or INPUT_PULLUP) mode for interrupts to work correctly. * Adjust list of available GPIO/GPI's on ESP32 in IRMQTTServer. * Add option to use `INPUT_PULLUP` via `IRrecv.enableIRIn(true)`. - Default is false. i.e. `INPUT` Tested on GOOUUU-ESP32 & a Olimex ESP32-EVB board. Confirmed working. Fixes #768
|
@darshkpatel thanks for reviewing. |
crankyoldgit
added a commit
that referenced
this pull request
Jul 4, 2019
_v2.6.3 (20190704)_ **[Bug Fixes]** - IRMQTTServer: REPLAY_DECODED_AC_MESSAGE not working. (#784, #797) - ESP32: Ensure `IRrecv`'s GPIO is set to input mode. (#774) **[Features]** - IRMQTTServer: Show available sketch space for OTA uploads. (#795) - Experimental detailed support for Electra/AUX protocol (#788) - IRMQTTServer: Ability to resend existing climate state via MQTT & HTTP (#784) - Daikin160: Add detailed & common a/c support. (#777) - Experimental detailed support for Neoclima protocol. (#767) - Gree: add WiFi and IFeel bits (#770) - Handle A/Cs with toggles better. (#758) - IRMQTTServer: Allow sending/receiving climate via JSON over MQTT. (#763) **[Misc]** - Move converting of IR A/C messages out of example code. (#798) - Reduce example code size and complexity (#790) - Change `ControlSamsungAC` example to not use `sendExtended()` (#792) - IRMQTTServer: Add MQTT_CLIMATE_IR_SEND_ON_RESTART compile-time flag. (#784) - Refactor A/C's toString()'s to reduce code size. Saves ~3.5k (#782) - Add sanity tests for unexpected conditions in IRrecv. (#773) - IRMQTTServer: Fixed the HA config documentation (missing '-') (#776) - Improve `mkkeywords` tool. (#766) - Refactor with generic decode routines in `IRrecv` class. Saves ~7k. (#765)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Jul 4, 2019
## _v2.6.3 (20190704)_ **[Bug Fixes]** - IRMQTTServer: REPLAY_DECODED_AC_MESSAGE not working. (#784, #797) - ESP32: Ensure `IRrecv`'s GPIO is set to input mode. (#774) **[Features]** - IRMQTTServer: Show available sketch space for OTA uploads. (#795) - Experimental detailed support for Electra/AUX protocol (#788) - IRMQTTServer: Ability to resend existing climate state via MQTT & HTTP (#784) - Daikin160: Add detailed & common a/c support. (#777) - Experimental detailed support for Neoclima protocol. (#767) - Gree: add WiFi and IFeel bits (#770) - Handle A/Cs with toggles better. (#758) - IRMQTTServer: Allow sending/receiving climate via JSON over MQTT. (#763) **[Misc]** - Move converting of IR A/C messages out of example code. (#798) - Reduce example code size and complexity (#790) - Change `ControlSamsungAC` example to not use `sendExtended()` (#792) - IRMQTTServer: Add MQTT_CLIMATE_IR_SEND_ON_RESTART compile-time flag. (#784) - Refactor A/C's toString()'s to reduce code size. Saves ~3.5k (#782) - Add sanity tests for unexpected conditions in IRrecv. (#773) - IRMQTTServer: Fixed the HA config documentation (missing '-') (#776) - Improve `mkkeywords` tool. (#766) - Refactor with generic decode routines in `IRrecv` class. Saves ~7k. (#765)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on different ESP32 boards highlighted that unlike ESP8266's
the GPIO needs to be explicitly set to INPUT (or INPUT_PULLUP) mode for
interrupts to work correctly.
Adjust list of available GPIO/GPI's on ESP32 in IRMQTTServer.
Add option to use
INPUT_PULLUPviaIRrecv.enableIRIn(true).INPUTFixes #768