Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce example code size and complexity #790

Merged
merged 10 commits into from
Jul 4, 2019
Merged

Reduce example code size and complexity #790

merged 10 commits into from
Jul 4, 2019

Conversation

crankyoldgit
Copy link
Owner

  • IRrecvDumpV2
    • Move generation of A/C text to IRac.cpp.
      • Allows unit test coverage
      • Removes need to change IRrecvDumpV2 every time a new A/C gets added.
      • Reduces size and complexity from example code.
    • Use new code to describe A/Cs in unit tests. Modify tests accordingly.
  • IRMQTTServer
    • Allow disabling of examples. Allows saving of ~2.5k of program space.
    • Remove duplicate code that is elsewhere in the library.
    • Move min repeat and default bit logic to the library so it can be tested.
    • Simplify IR sending logic a bit.
    • Simplify setting the state size for ac-like messages.
    • Add ability to disable MQTT discovery message for aircon. saves ~1.5k if needed.
    • Consolidate calls to ESP.restart().

@crankyoldgit crankyoldgit self-assigned this Jun 30, 2019
@crankyoldgit
IRrecvDumpV2: Move A/C description text to IRac.cpp
7fec5aa 
* Move generation of A/C text to IRac.cpp.
  - Allows unit test coverage
  - Removes need to change IRrecvDumpV2 every time a new A/C gets added.
  - Reduces size and complexity from example code.

* Use new code to describe A/Cs in unit tests. Modify tests accordingly.
@crankyoldgit
IRMQTTServer: Allow disabling of examples to save ~2.5k of prog space.
1318c0c
@crankyoldgit
Simplify IRMQTTServer code.
5161beb 
* Remove duplicate code that is elsewhere in the library.
* Move min repeat and default bit logic to the library so it can be tested.
* Simplify IR sending logic a bit.
@crankyoldgit
Simplify A/C state size determination.
a26c0c7 
* Simplify setting the state size for ac-like messages.
* Add ability to disable MQTT discovery message for aircon. saves 1.5k if needed.
@crankyoldgit
Consolidate ESP.restart()s
012bd8d 
* Deduplicate code around restarts.
* Change mqttLog() to use `char *` instead of String(). Saves a few bytes.
@crankyoldgit
Update version to 1.3.0-alpha
ab4389e
@crankyoldgit
Merge in Daikin160 support.
4fbc842
@crankyoldgit crankyoldgit force-pushed the reduce_example_code branch from ba8cf45 to 4fbc842 Compare July 1, 2019 09:11
crankyoldgit and others added 3 commits July 2, 2019 18:35
@crankyoldgit
Merge branch 'master' into reduce_example_code
baacc0d
@crankyoldgit
Fix problem introduce after merge with master branch
bdd9385
@crankyoldgit
Unit test coverage for refactored code.
5e7cfa8 
* Tests for `defaultBits()`
  - Fix/add RC5X and RC5.
* Tests for `strToDecodeType()` & `typeToString()`
  - Add missing Mitsubishi Heavy protocols
  - Handle NEC_LIKE correctly.
* Tests to ensure every real protocol has a corresponding `IRsend::send()` entry.
@crankyoldgit crankyoldgit merged commit 1b34ce4 into master Jul 4, 2019
crankyoldgit added a commit that referenced this pull request Jul 4, 2019
@crankyoldgit
Move converting of IR A/C messages out of example code.
fa96f14 
Ref #790
@crankyoldgit crankyoldgit mentioned this pull request Jul 4, 2019
Merged
crankyoldgit added a commit that referenced this pull request Jul 4, 2019
@crankyoldgit
Move converting of IR A/C messages out of example code. (#798)
a4419fe 
Ref #790
crankyoldgit added a commit that referenced this pull request Jul 4, 2019
@crankyoldgit
v2.6.3 release
2faa6ed 
_v2.6.3 (20190704)_

**[Bug Fixes]**
- IRMQTTServer: REPLAY_DECODED_AC_MESSAGE not working. (#784, #797)
- ESP32: Ensure `IRrecv`'s GPIO is set to input mode. (#774)

**[Features]**
- IRMQTTServer: Show available sketch space for OTA uploads. (#795)
- Experimental detailed support for Electra/AUX protocol (#788)
- IRMQTTServer: Ability to resend existing climate state via MQTT & HTTP (#784)
- Daikin160: Add detailed & common a/c support. (#777)
- Experimental detailed support for Neoclima protocol. (#767)
- Gree: add WiFi and IFeel bits (#770)
- Handle A/Cs with toggles better. (#758)
- IRMQTTServer: Allow sending/receiving climate via JSON over MQTT. (#763)

**[Misc]**
- Move converting of IR A/C messages out of example code. (#798)
- Reduce example code size and complexity (#790)
- Change `ControlSamsungAC` example to not use `sendExtended()` (#792)
- IRMQTTServer: Add MQTT_CLIMATE_IR_SEND_ON_RESTART compile-time flag. (#784)
- Refactor A/C's toString()'s to reduce code size. Saves ~3.5k (#782)
- Add sanity tests for unexpected conditions in IRrecv. (#773)
- IRMQTTServer: Fixed the HA config documentation (missing '-') (#776)
- Improve `mkkeywords` tool. (#766)
- Refactor with generic decode routines in `IRrecv` class. Saves ~7k. (#765)
@crankyoldgit crankyoldgit mentioned this pull request Jul 4, 2019
Merged
@crankyoldgit crankyoldgit deleted the reduce_example_code branch July 4, 2019 08:13
crankyoldgit added a commit that referenced this pull request Jul 4, 2019
@crankyoldgit
v2.6.3 release (#799)
6313a70 
## _v2.6.3 (20190704)_

**[Bug Fixes]**
- IRMQTTServer: REPLAY_DECODED_AC_MESSAGE not working. (#784, #797)
- ESP32: Ensure `IRrecv`'s GPIO is set to input mode. (#774)

**[Features]**
- IRMQTTServer: Show available sketch space for OTA uploads. (#795)
- Experimental detailed support for Electra/AUX protocol (#788)
- IRMQTTServer: Ability to resend existing climate state via MQTT & HTTP (#784)
- Daikin160: Add detailed & common a/c support. (#777)
- Experimental detailed support for Neoclima protocol. (#767)
- Gree: add WiFi and IFeel bits (#770)
- Handle A/Cs with toggles better. (#758)
- IRMQTTServer: Allow sending/receiving climate via JSON over MQTT. (#763)

**[Misc]**
- Move converting of IR A/C messages out of example code. (#798)
- Reduce example code size and complexity (#790)
- Change `ControlSamsungAC` example to not use `sendExtended()` (#792)
- IRMQTTServer: Add MQTT_CLIMATE_IR_SEND_ON_RESTART compile-time flag. (#784)
- Refactor A/C's toString()'s to reduce code size. Saves ~3.5k (#782)
- Add sanity tests for unexpected conditions in IRrecv. (#773)
- IRMQTTServer: Fixed the HA config documentation (missing '-') (#776)
- Improve `mkkeywords` tool. (#766)
- Refactor with generic decode routines in `IRrecv` class. Saves ~7k. (#765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwarden bwarden Awaiting requested review from bwarden

@sillyfrog sillyfrog Awaiting requested review from sillyfrog

@darshkpatel darshkpatel Awaiting requested review from darshkpatel

@markszabo markszabo Awaiting requested review from markszabo

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crankyoldgit