Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle A/Cs with toggles better. #758

Merged
merged 2 commits into from
Jun 23, 2019
Merged

Handle A/Cs with toggles better. #758

merged 2 commits into from
Jun 23, 2019

Conversation

crankyoldgit
Copy link
Owner

  • Add class method to send from a state_t type.
    • If given the previous state, try to handle toggles intelligently.
  • Move compare state function out of example code into class library.
  • Unit tests covering the new functionality.

@crankyoldgit crankyoldgit self-assigned this Jun 16, 2019
@crankyoldgit
Handle A/Cs with toggles better.
9325ea2 
* Add class method to send from a state_t type.
  - If given the previous state, try to handle toggles intelligently.
* Move compare state function out of example code into class library.
* Unit tests covering the new functionality.
@crankyoldgit
Copy link
Owner Author

No feedback after a week. Merging.

@crankyoldgit crankyoldgit merged commit 056a0d0 into master Jun 23, 2019
@crankyoldgit crankyoldgit deleted the common_ac_toggles branch June 23, 2019 07:56
@crankyoldgit crankyoldgit mentioned this pull request Jun 27, 2019
Closed
crankyoldgit added a commit that referenced this pull request Jul 4, 2019
@crankyoldgit
v2.6.3 release
2faa6ed 
_v2.6.3 (20190704)_

**[Bug Fixes]**
- IRMQTTServer: REPLAY_DECODED_AC_MESSAGE not working. (#784, #797)
- ESP32: Ensure `IRrecv`'s GPIO is set to input mode. (#774)

**[Features]**
- IRMQTTServer: Show available sketch space for OTA uploads. (#795)
- Experimental detailed support for Electra/AUX protocol (#788)
- IRMQTTServer: Ability to resend existing climate state via MQTT & HTTP (#784)
- Daikin160: Add detailed & common a/c support. (#777)
- Experimental detailed support for Neoclima protocol. (#767)
- Gree: add WiFi and IFeel bits (#770)
- Handle A/Cs with toggles better. (#758)
- IRMQTTServer: Allow sending/receiving climate via JSON over MQTT. (#763)

**[Misc]**
- Move converting of IR A/C messages out of example code. (#798)
- Reduce example code size and complexity (#790)
- Change `ControlSamsungAC` example to not use `sendExtended()` (#792)
- IRMQTTServer: Add MQTT_CLIMATE_IR_SEND_ON_RESTART compile-time flag. (#784)
- Refactor A/C's toString()'s to reduce code size. Saves ~3.5k (#782)
- Add sanity tests for unexpected conditions in IRrecv. (#773)
- IRMQTTServer: Fixed the HA config documentation (missing '-') (#776)
- Improve `mkkeywords` tool. (#766)
- Refactor with generic decode routines in `IRrecv` class. Saves ~7k. (#765)
@crankyoldgit crankyoldgit mentioned this pull request Jul 4, 2019
Merged
crankyoldgit added a commit that referenced this pull request Jul 4, 2019
@crankyoldgit
v2.6.3 release (#799)
6313a70 
## _v2.6.3 (20190704)_

**[Bug Fixes]**
- IRMQTTServer: REPLAY_DECODED_AC_MESSAGE not working. (#784, #797)
- ESP32: Ensure `IRrecv`'s GPIO is set to input mode. (#774)

**[Features]**
- IRMQTTServer: Show available sketch space for OTA uploads. (#795)
- Experimental detailed support for Electra/AUX protocol (#788)
- IRMQTTServer: Ability to resend existing climate state via MQTT & HTTP (#784)
- Daikin160: Add detailed & common a/c support. (#777)
- Experimental detailed support for Neoclima protocol. (#767)
- Gree: add WiFi and IFeel bits (#770)
- Handle A/Cs with toggles better. (#758)
- IRMQTTServer: Allow sending/receiving climate via JSON over MQTT. (#763)

**[Misc]**
- Move converting of IR A/C messages out of example code. (#798)
- Reduce example code size and complexity (#790)
- Change `ControlSamsungAC` example to not use `sendExtended()` (#792)
- IRMQTTServer: Add MQTT_CLIMATE_IR_SEND_ON_RESTART compile-time flag. (#784)
- Refactor A/C's toString()'s to reduce code size. Saves ~3.5k (#782)
- Add sanity tests for unexpected conditions in IRrecv. (#773)
- IRMQTTServer: Fixed the HA config documentation (missing '-') (#776)
- Improve `mkkeywords` tool. (#766)
- Refactor with generic decode routines in `IRrecv` class. Saves ~7k. (#765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sillyfrog sillyfrog Awaiting requested review from sillyfrog

@rahuljawale rahuljawale Awaiting requested review from rahuljawale

@markszabo markszabo Awaiting requested review from markszabo

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crankyoldgit