Reduce duplicate code to save space. #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename some functions in IRutils. * Refactor string building functions to reduce duplicate code. * Add more fuctions to reduce code duplication. * Modify some unit tests accordingly. * Rename namespace to meet style guide.
* Adjust unit tests for a more standardised solution to fan speed text. * Total prog space saving at ~3k so far.
move msToString() to IRutils
|
No feedback after 7 days. Merging to master. |
crankyoldgit
added a commit
that referenced
this pull request
Jul 26, 2019
_v2.6.4 (20190726)_ **[Bug Fixes]** - Fix some swing problems with the Mitsubishi HAVC protocol (#831) - Fix parameter ordering for Gree in common a/c code. (#815) - Fix parameters for Coolix in IRac::sendAc() (#829) - IRMQTTServer: Fix sending >64 bit codes. (#811) **[Features]** - Daikin128: Full detailed support & common a/c support. (#832) - Midea: Support native temp units of Celsius & SwingV. (#823) - Gree: Support `YBOFB` models and bug fix. (#815) - Pioneer: Fix sendPioneer with Pioneer specific timings (#830) - Daikin128: Initial support for Daikin 17 Series/BRC52B63 (#828) - Coolix: Better `toCommon()` support. (#825) - Experimental detailed support for Daikin 176 bits (#816) - Add setting of output options to A/C classes. (#808) - Add invert flag support to Samsung AC (#807) **[Misc]** - Daikin176: making some change on Daikin176 to work with IRMQTTServer (#826) - Reduce duplicate code to save (3K+) space. (#813) - Daikin176: Experiment Daikin176bits with IRMQTTServer (#824) - Update platformio.ini files for PlatformIO v4.0.0 (#812) - Change repo URLs to new location. (#806) - Move `htmlEscape()` to the IRutils namespace (#801)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Jul 26, 2019
_v2.6.4 (20190726)_ **[Bug Fixes]** - Fix some swing problems with the Mitsubishi HAVC protocol (#831) - Fix parameter ordering for Gree in common a/c code. (#815) - Fix parameters for Coolix in IRac::sendAc() (#829) - IRMQTTServer: Fix sending >64 bit codes. (#811) **[Features]** - Daikin128: Full detailed support & common a/c support. (#832) - Midea: Support native temp units of Celsius & SwingV. (#823) - Gree: Support `YBOFB` models and bug fix. (#815) - Pioneer: Fix sendPioneer with Pioneer specific timings (#830) - Daikin128: Initial support for Daikin 17 Series/BRC52B63 (#828) - Coolix: Better `toCommon()` support. (#825) - Experimental detailed support for Daikin 176 bits (#816) - Add setting of output options to A/C classes. (#808) - Add invert flag support to Samsung AC (#807) **[Misc]** - Daikin176: making some change on Daikin176 to work with IRMQTTServer (#826) - Reduce duplicate code to save (3K+) space. (#813) - Daikin176: Experiment Daikin176bits with IRMQTTServer (#824) - Update platformio.ini files for PlatformIO v4.0.0 (#812) - Change repo URLs to new location. (#806) - Move `htmlEscape()` to the IRutils namespace (#801)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All in all, saves about 3k+ of prog space.
Use a common minsToString() routine.
Refactor a/c string building functions to reduce duplicate code.
Create addFanToString.
Remove duplicate code in htmlSelect routines.
Modify & add unit tests accordingly.
Rename namespace to meet style guide.