Fix sendPioneer with Pioneer specific timings #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @s-hadinger, thanks for this. I'll look at cleaning this up shortly. e,g, Unit tests will be failing at the very least. Do you have any Code comments to follow :) |
crankyoldgit
requested changes
Jul 22, 2019
* Fix some code style issues so it is consistent with the rest of the code base. * Fix a bunch of linter errors. * Update existing unit tests to reflect the code changes. FYI @s-hadinger
crankyoldgit
approved these changes
Jul 23, 2019
jorgecis
added a commit
to jorgecis/IRremoteESP8266
that referenced
this pull request
Jul 23, 2019
Fix sendPioneer with Pioneer specific timings (crankyoldgit#830)
|
Hi, No I don't have full capture of long presses. But from the capture I have, the repeat is definitely not the NEC's one. Thanks for integrating the changes so fast. |
Pity.
No worries. |
crankyoldgit
added a commit
that referenced
this pull request
Jul 26, 2019
_v2.6.4 (20190726)_ **[Bug Fixes]** - Fix some swing problems with the Mitsubishi HAVC protocol (#831) - Fix parameter ordering for Gree in common a/c code. (#815) - Fix parameters for Coolix in IRac::sendAc() (#829) - IRMQTTServer: Fix sending >64 bit codes. (#811) **[Features]** - Daikin128: Full detailed support & common a/c support. (#832) - Midea: Support native temp units of Celsius & SwingV. (#823) - Gree: Support `YBOFB` models and bug fix. (#815) - Pioneer: Fix sendPioneer with Pioneer specific timings (#830) - Daikin128: Initial support for Daikin 17 Series/BRC52B63 (#828) - Coolix: Better `toCommon()` support. (#825) - Experimental detailed support for Daikin 176 bits (#816) - Add setting of output options to A/C classes. (#808) - Add invert flag support to Samsung AC (#807) **[Misc]** - Daikin176: making some change on Daikin176 to work with IRMQTTServer (#826) - Reduce duplicate code to save (3K+) space. (#813) - Daikin176: Experiment Daikin176bits with IRMQTTServer (#824) - Update platformio.ini files for PlatformIO v4.0.0 (#812) - Change repo URLs to new location. (#806) - Move `htmlEscape()` to the IRutils namespace (#801)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Jul 26, 2019
_v2.6.4 (20190726)_ **[Bug Fixes]** - Fix some swing problems with the Mitsubishi HAVC protocol (#831) - Fix parameter ordering for Gree in common a/c code. (#815) - Fix parameters for Coolix in IRac::sendAc() (#829) - IRMQTTServer: Fix sending >64 bit codes. (#811) **[Features]** - Daikin128: Full detailed support & common a/c support. (#832) - Midea: Support native temp units of Celsius & SwingV. (#823) - Gree: Support `YBOFB` models and bug fix. (#815) - Pioneer: Fix sendPioneer with Pioneer specific timings (#830) - Daikin128: Initial support for Daikin 17 Series/BRC52B63 (#828) - Coolix: Better `toCommon()` support. (#825) - Experimental detailed support for Daikin 176 bits (#816) - Add setting of output options to A/C classes. (#808) - Add invert flag support to Samsung AC (#807) **[Misc]** - Daikin176: making some change on Daikin176 to work with IRMQTTServer (#826) - Reduce duplicate code to save (3K+) space. (#813) - Daikin176: Experiment Daikin176bits with IRMQTTServer (#824) - Update platformio.ini files for PlatformIO v4.0.0 (#812) - Change repo URLs to new location. (#806) - Move `htmlEscape()` to the IRutils namespace (#801)
|
FYI, this PR has been included in the v2.6.4 release of the library. |
|
Thanks a lot. I will update Tasmota with this new version, unless Theo does it before me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposal to adjust timing for sendPioneer. Pioneer encoding is identical to NEC, but timing or slightly different. As frequency is 40KHz instead of 38KHz, it looks like the number of pulses are the same as NEC, hence timing is 5% shorter. For example, NEC preamble is 9.0ms/4.5ms, whereas Pioneer preamble is 8.5ms/4.25ms.
Most Pioneer devices accept NEC timings, but some don't. This change will hopefully make it comatible with all devices.
See: arendst/Tasmota#6100
I also changed the following:
repeatnow resend the full 64 bits sequence, instead of the NEC specific repeatHope this helps!