Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gree: Support YBOFB models. #815

Merged
merged 6 commits into from
Jul 23, 2019
Merged

Gree: Support YBOFB models. #815

merged 6 commits into from
Jul 23, 2019

Conversation

crankyoldgit
Copy link
Owner

@crankyoldgit crankyoldgit commented Jul 15, 2019 •
edited
Loading

  • Add set/getModel(). e.g. YAW1F (1) [default] & YBOFB2 (2)
  • Automatic detection of models only works with messages with power on.
  • set/getPower() now changes behaviour with different models.
  • Report model type in the .toString() function.
  • Update common a/c routines and unit tests.
  • Unit test coverage for different power/model operation.
  • [BUG] Fix parameter ordering for Gree in common a/c code.

For #814

@crankyoldgit crankyoldgit self-assigned this Jul 15, 2019
@jimmys01
Copy link
Contributor

perhaps solves #569 also

@crankyoldgit
Copy link
Owner Author

@jimmys01 I agree, it will probably report the correct power state for that one too now. However I'm more concerned that it still controls a unit correctly, rather than decodes one correctly.

Something is certainly odd with the Gree protocol between all the vendors. Hopefully someday we will get to the bottom of it. :-/

@crankyoldgit crankyoldgit changed the title Gree: Use less strict power mode detection. Gree: Support YBOFB2 models. Jul 15, 2019
@crankyoldgit
Copy link
Owner Author

Confirmed working in: #814 (comment)

@crankyoldgit crankyoldgit changed the title Gree: Support YBOFB2 models. Gree: Support YBOFB models. Jul 16, 2019
@crankyoldgit crankyoldgit mentioned this pull request Jul 18, 2019
Closed
@crankyoldgit
Gree: Use less strict power mode detection.
63d6059 
Reported data in #814 indicates state[0] is the only thing that changes 
for power on/off.

Leave the existing bit setting/clearing for setPower() etc, but don't 
require the state[2] bit for getPower().

Fixes #814
@crankyoldgit
Gree: Add differing model support.
ee0a288 
* Add set/getModel(). e.g. YAW1F (1) [default] & YBOFB2 (2)
* Automatic detection of models only works with messages with power on.
* set/getPower() now changes behaviour with different models.
* Report model type in the .toString() function.
* Update common a/c routines and unit tests.
* Unit test coverage for different power/model operation.

Fixes #814
@crankyoldgit
Update model info.
f9c683a
@crankyoldgit
Update supported model info
d19182a 
Ref: 
#814 (comment)
@crankyoldgit
Fixes for a poor merge.
7de1bc9
@crankyoldgit crankyoldgit merged commit b6e3c9f into master Jul 23, 2019
@crankyoldgit
Copy link
Owner Author

Merged after no negative code review feedback after 7+ days,

crankyoldgit added a commit that referenced this pull request Jul 26, 2019
@crankyoldgit
v2.6.4 release
65b0ae5 
_v2.6.4 (20190726)_

**[Bug Fixes]**
- Fix some swing problems with the Mitsubishi HAVC protocol (#831)
- Fix parameter ordering for Gree in common a/c code. (#815)
- Fix parameters for Coolix in IRac::sendAc() (#829)
- IRMQTTServer: Fix sending >64 bit codes. (#811)

**[Features]**
- Daikin128: Full detailed support & common a/c support. (#832)
- Midea: Support native temp units of Celsius & SwingV. (#823)
- Gree: Support `YBOFB` models and bug fix. (#815)
- Pioneer: Fix sendPioneer with Pioneer specific timings (#830)
- Daikin128: Initial support for Daikin 17 Series/BRC52B63 (#828)
- Coolix: Better `toCommon()` support. (#825)
- Experimental detailed support for Daikin 176 bits (#816)
- Add setting of output options to A/C classes. (#808)
- Add invert flag support to Samsung AC (#807)

**[Misc]**
- Daikin176: making some change on Daikin176 to work with IRMQTTServer (#826)
- Reduce duplicate code to save (3K+) space. (#813)
- Daikin176: Experiment Daikin176bits with IRMQTTServer (#824)
- Update platformio.ini files for PlatformIO v4.0.0 (#812)
- Change repo URLs to new location. (#806)
- Move `htmlEscape()` to the IRutils namespace (#801)
@crankyoldgit crankyoldgit mentioned this pull request Jul 26, 2019
Merged
crankyoldgit added a commit that referenced this pull request Jul 26, 2019
@crankyoldgit
v2.6.4 release (#833)
a2455ca 
_v2.6.4 (20190726)_

**[Bug Fixes]**
- Fix some swing problems with the Mitsubishi HAVC protocol (#831)
- Fix parameter ordering for Gree in common a/c code. (#815)
- Fix parameters for Coolix in IRac::sendAc() (#829)
- IRMQTTServer: Fix sending >64 bit codes. (#811)

**[Features]**
- Daikin128: Full detailed support & common a/c support. (#832)
- Midea: Support native temp units of Celsius & SwingV. (#823)
- Gree: Support `YBOFB` models and bug fix. (#815)
- Pioneer: Fix sendPioneer with Pioneer specific timings (#830)
- Daikin128: Initial support for Daikin 17 Series/BRC52B63 (#828)
- Coolix: Better `toCommon()` support. (#825)
- Experimental detailed support for Daikin 176 bits (#816)
- Add setting of output options to A/C classes. (#808)
- Add invert flag support to Samsung AC (#807)

**[Misc]**
- Daikin176: making some change on Daikin176 to work with IRMQTTServer (#826)
- Reduce duplicate code to save (3K+) space. (#813)
- Daikin176: Experiment Daikin176bits with IRMQTTServer (#824)
- Update platformio.ini files for PlatformIO v4.0.0 (#812)
- Change repo URLs to new location. (#806)
- Move `htmlEscape()` to the IRutils namespace (#801)
@crankyoldgit crankyoldgit deleted the Issue814 branch July 31, 2019 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahuljawale rahuljawale Awaiting requested review from rahuljawale

@darshkpatel darshkpatel Awaiting requested review from darshkpatel

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crankyoldgit @jimmys01