fix: seed examples files when no e2e directory is created #19768
Conversation
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| @@ -36,6 +36,9 @@ export async function codeGenerator ( | |||
| const templateFiles = await allFilesInDir(action.templateDir) | |||
| const codeGenResults: CodeGenResults = { files: [], failed: [] } | |||
|
|
|||
| // checks if the target directory exists and creates it if necessary | |||
| await fs.ensureDir(action.target) | |||
There was a problem hiding this comment.
This is unnecessary, since the generator uses fs.outputFile to generate files which will create the directory if it does not exist.
There was a problem hiding this comment.
Added it to replace this function maybeCreateE2EDir() that failed.
Asking stats on a non-existing directory does not work.
I hope it is not useful.
packages/app/cypress/e2e/files.cy.ts
Outdated
| @@ -12,3 +14,18 @@ describe('App', () => { | |||
| cy.get('[href="#/settings"]').click() | |||
| }) | |||
| }) | |||
|
|
|||
| describe('example files', () => { | |||
There was a problem hiding this comment.
We already have a test for this that you can update if need be, we shouldn't duplicate the test.
There was a problem hiding this comment.
Agreed for improving the test.
We need to catch the "no file has been created" error
And we should catch the "Dialog opens in a blink and closes" error
|
@ZachJW34 included your remarks, you can review and feel free to merge. |
* 10.0-release: (25 commits) fix(unify): improve dev server config ergonomics (#19957) feat: add spec pattern modal (#19801) fix: Windows e2e project scaffolding issues (#19938) feat: update @cypress/schematic to use proper e2e config for 10.0.0 (#19827) fix: correctly migrate projects with custom integration folder (#19929) fix: component spec creation with spec pattern (#19862) fix: missed committing yarn.lock after merge conflict fix: correct reference branch / commitSha in performance-reporter (#19941) feat: update navbar UI per Figma (#19926) fix: seed examples files when no e2e directory is created (#19768) chore: remove windy lightBlue warning test: component test updates (#19925) feat: Focus browser from select browser screen and on dashboard login (#19842) test: Honeycomb system-test reporter (#19855) fix(deps): update dependency engine.io to v5.2.1 [security] feat: Retain fileName when working with aliased fixtures and files (#19820) Update release-process.md Update release-process.md Update release-process.md Update release-process.md ...
Bug
On that screen click scaffold
See the error
Diagnosis
The
cypress/e2edirectory is read before it is created.