fix: component spec creation with spec pattern #19862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||
…jandro/fix/component-spec-creation
…jandro/fix/component-spec-creation
…jandro/fix/component-spec-creation
…press-io/cypress into alejandro/fix/component-spec-creation
lmiller1990
approved these changes
Jan 28, 2022
| @@ -47,7 +47,7 @@ const isRunMode = window.__CYPRESS_MODE__ === 'run' | |||
| // requests, which is what we want. | |||
| const query = useQuery({ | |||
| query: SpecPageContainerDocument, | |||
| requestPolicy: 'cache-and-network', | |||
| requestPolicy: 'cache-only', | |||
| import { unionType } from 'nexus' | ||
|
|
||
| export const GeneratedSpecResult = unionType({ | ||
| name: 'GeneratedSpecResult', |
There was a problem hiding this comment.
Did not know about this, very nice
| baseName: 'Basic', | ||
| fileExtension: 'tsx', | ||
| contents: `it('should do stuff', () => {})`, | ||
| currentProject: ctx.currentProject, |
There was a problem hiding this comment.
Starting to wonder how useful the stubgql mutations are, they are really hard to keep up to date w/ real data
| @@ -358,6 +395,28 @@ export class ProjectActions { | |||
|
|
|||
| const [newSpec] = codeGenResults.files | |||
|
|
|||
| const cfg = this.ctx.project.getConfig() | |||
|
|
|||
| if (cfg) { | |||
There was a problem hiding this comment.
Not sure when or where but we really need to centralize this - it's a copy paste of some really complex and important code
tgriesser
added a commit
that referenced
this pull request
Jan 31, 2022
* 10.0-release: (25 commits) fix(unify): improve dev server config ergonomics (#19957) feat: add spec pattern modal (#19801) fix: Windows e2e project scaffolding issues (#19938) feat: update @cypress/schematic to use proper e2e config for 10.0.0 (#19827) fix: correctly migrate projects with custom integration folder (#19929) fix: component spec creation with spec pattern (#19862) fix: missed committing yarn.lock after merge conflict fix: correct reference branch / commitSha in performance-reporter (#19941) feat: update navbar UI per Figma (#19926) fix: seed examples files when no e2e directory is created (#19768) chore: remove windy lightBlue warning test: component test updates (#19925) feat: Focus browser from select browser screen and on dashboard login (#19842) test: Honeycomb system-test reporter (#19855) fix(deps): update dependency engine.io to v5.2.1 [security] feat: Retain fileName when working with aliased fixtures and files (#19820) Update release-process.md Update release-process.md Update release-process.md Update release-process.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?