feat: update navbar UI per Figma #19926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
elevatebart
reviewed
Jan 26, 2022
| @@ -1,5 +1,5 @@ | |||
| <template> | |||
| <div class="bg-white border-b border-b-gray-100 py-15px px-6"> | |||
There was a problem hiding this comment.
This height should be dictated by the grid container right?
There was a problem hiding this comment.
Good catch, replaced with h-full. For context, I made this change since the navbar-header and app-header were not aligning (app-header wasn't growing to full 64px)
Edit: Reverted
elevatebart
previously approved these changes
Jan 26, 2022
|
Test summary
Run details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
elevatebart
previously approved these changes
Jan 27, 2022
|
@elevatebart reverted the |
elevatebart
previously approved these changes
Jan 27, 2022
elevatebart
approved these changes
Jan 27, 2022
tgriesser
added a commit
that referenced
this pull request
Jan 31, 2022
* 10.0-release: (25 commits) fix(unify): improve dev server config ergonomics (#19957) feat: add spec pattern modal (#19801) fix: Windows e2e project scaffolding issues (#19938) feat: update @cypress/schematic to use proper e2e config for 10.0.0 (#19827) fix: correctly migrate projects with custom integration folder (#19929) fix: component spec creation with spec pattern (#19862) fix: missed committing yarn.lock after merge conflict fix: correct reference branch / commitSha in performance-reporter (#19941) feat: update navbar UI per Figma (#19926) fix: seed examples files when no e2e directory is created (#19768) chore: remove windy lightBlue warning test: component test updates (#19925) feat: Focus browser from select browser screen and on dashboard login (#19842) test: Honeycomb system-test reporter (#19855) fix(deps): update dependency engine.io to v5.2.1 [security] feat: Retain fileName when working with aliased fixtures and files (#19820) Update release-process.md Update release-process.md Update release-process.md Update release-process.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Update navbar UI to match Figma mocks
Additional details
The testing type switcher has moved into the header and some colors have been tweaked
How has the user experience changed?
Screen.Recording.2022-01-26.at.4.51.54.PM.mov
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?