FIX: change c includes to account for upstream changes

[tacaswell]

python/cpython#28968 / 8e5de40f90476249e9a2e5ef135143b5c6a0b512 which is part of implementing https://bugs.python.org/issue35134 moved the header "longintrepr.h" into a sub-folder. The notes on this change suggested to include "Python.h" instead.

[da-woods]

I think this needs #if PY_VERSION_HEX guards, at least for Python 2.7

For the pxd file the easiest way to do that is

cdef extern from *:
    """"
    #if PY_VERSION_HEX >= 0x03000000
     #include "xx"
    #else
     #include "yy"
    #endif
    """
    ... # contents as before...

[scoder]

I think what we're essentially saying here is "we always need Python.h anyway, but in Py2.7, we also need longintrepr.h". Let's spell it that way.

[tacaswell]

The failures appears to be exttype_total_ordering.ExtTypeTotalOrderingNeGt, but I do not have a OSX machine to debug on.

[da-woods]

ExtTypeTotalOrderingNeGt

I think that's a pre-existing failure on the master branch

[scoder]

Thanks.

[scoder]

0.29.x: 0f7bd0d

[l1x]

What is the workaround?

[scoder]

What is the workaround?

The best "work-around" is probably to use the latest Cython releases.

[l1x]

What is the workaround?

The best "work-around" is probably to use the latest Cython releases.

Let me be a bit more precise. I have a Debian 12 server and I would like to use Python 3.11. What is the workaround that I can use to have Python 3.11 without compiling Python myself? Is there a way to install longintrepr.h?

[tacaswell]

@l1x This due to a change to CPython to no longer include that header. If you are feeling particularly bloody minded I guess you could put an empty file with the right name someplace that the compiler will see but that seems like a Bad Idea™️ .

The best fix is to update the version of cython you are using and re-cythonize your source.

[dnabanita7]

I am still getting this issue

/anaconda3/envs/tts/include -arch arm64 -fPIC -O2 -isystem /Users/dnabanita7/anaconda3/envs/tts/include -arch arm64 -I /opt/homebrew/opt/protobuf/include -I/usr/local/include/ -I/private/var/folders/_m/4y30kv853fg5mxzh8574czq80000gn/T/pip-install-n4rd5tst/pycld3_2ddc0107d9c54442a6fb7aa615689cd3/src/ -I/private/var/folders/_m/4y30kv853fg5mxzh8574czq80000gn/T/pip-install-n4rd5tst/pycld3_2ddc0107d9c54442a6fb7aa615689cd3/src/cld_3/protos/ -I/Users/dnabanita7/anaconda3/envs/tts/include/python3.11 -c cld3/pycld3.cpp -o build/temp.macosx-11.0-arm64-cpython-311/cld3/pycld3.o -std=c++11 -stdlib=libc++
      cld3/pycld3.cpp:250:12: fatal error: 'longintrepr.h' file not found
        #include "longintrepr.h"
                 ^~~~~~~~~~~~~~~
      1 error generated.
      error: command '/opt/homebrew/opt/llvm/bin/clang' failed with exit code 1

I can't update cython version as its not compatible with coqui-tts. Also upgrading cython version to 3.0.0 doesn't woek either. I am using ventura osx m2 chip.

[da-woods]

I can't update cython version as its not compatible with coqui-tts

Then you're stuck and there is no possible solution that lets you use Python 3.11.

I suggest you use Python 3.10 or earlier.

[dnabanita7]

yea, changed back it to 3.10. It's working fine. Thanks!

…

On Thu, Aug 17, 2023 at 12:24 PM da-woods ***@***.***> wrote: I can't update cython version as its not compatible with coqui-tts Then you're stuck and there is no possible solution that lets you use Python 3.11. I suggest you use Python 3.10 or earlier. — Reply to this email directly, view it on GitHub <#4428 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHQZX5ZYED5SWSQFBXZ7DRDXVZASFANCNFSM5GY3SCJQ> . You are receiving this because you commented.Message ID: ***@***.***>

-- *nabanita*

[muhannad-hash]

still have this issue