Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35134: Move classobject.h to Include/cpython/ #28968

Merged
merged 1 commit into from
Oct 15, 2021
Merged

bpo-35134: Move classobject.h to Include/cpython/ #28968

merged 1 commit into from
Oct 15, 2021

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 15, 2021

Move classobject.h, context.h, genobject.h and longintrepr.h header
files from Include/ to Include/cpython/.

Remove redundant "#ifndef Py_LIMITED_API" in context.h.

Remove explicit #include "longintrepr.h" in C files. It's not needed,
Python.h already includes it.

https://bugs.python.org/issue35134

Move classobject.h, context.h, genobject.h and longintrepr.h header
files from Include/ to Include/cpython/.

Remove redundant "#ifndef Py_LIMITED_API" in context.h.

Remove explicit #include "longintrepr.h" in C files. It's not needed,
Python.h already includes it.
@vstinner vstinner merged commit 8e5de40 into python:main Oct 15, 2021
@vstinner vstinner deleted the classobject branch October 15, 2021 07:46
ShivnarenSrinivasan pushed a commit to ShivnarenSrinivasan/cpython that referenced this pull request Oct 15, 2021
Move classobject.h, context.h, genobject.h and longintrepr.h header
files from Include/ to Include/cpython/.

Remove redundant "#ifndef Py_LIMITED_API" in context.h.

Remove explicit #include "longintrepr.h" in C files. It's not needed,
Python.h already includes it.
tacaswell added a commit to tacaswell/cython that referenced this pull request Oct 28, 2021
python/cpython#28968 /
8e5de40f90476249e9a2e5ef135143b5c6a0b512 which is part of implementing
https://bugs.python.org/issue35134 moved the header "longintrepr.h" into a
sub-folder.  The notes on this change suggested to include "Python.h" instead.
tacaswell added a commit to tacaswell/cython that referenced this pull request Oct 28, 2021
python/cpython#28968 /
8e5de40f90476249e9a2e5ef135143b5c6a0b512 which is part of implementing
https://bugs.python.org/issue35134 moved the header "longintrepr.h" into a
sub-folder.  The notes on this change suggested to include "Python.h" instead.
scoder pushed a commit to cython/cython that referenced this pull request Oct 31, 2021
…H-4428)

See python/cpython#28968
which is part of implementing
https://bugs.python.org/issue35134
moved the header "longintrepr.h" into a sub-folder.
The notes on this change suggested to include "Python.h" instead.
scoder pushed a commit to cython/cython that referenced this pull request Oct 31, 2021
…H-4428)

See python/cpython#28968
which is part of implementing
https://bugs.python.org/issue35134
moved the header "longintrepr.h" into a sub-folder.
The notes on this change suggested to include "Python.h" instead.
@Nebu1eto Nebu1eto mentioned this pull request Nov 5, 2022
@lexson-luo
Copy link

"Remove explicit #include "longintrepr.h" in C files. It's not needed,
Python.h already includes it." may i check which C files has this line? and which are those C files located?

@vstinner
Copy link
Member Author

may i check which C files has this line? and which are those C files located?

You can search for # *include.*longintrepr regular expression. For example, on Linux, find -name '*.c' -print0|xargs -0 grep -l -E '# *include.*longintrepr' lists C files which include this header file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants