… element without role (dequelabs#3243)

chore(release): 4.3.5

chore: merge master

* chore: update dependencies

* backpin mocha

…#3194)

* refactor(checks/navigation): improve `internal-link-present-evaluate`

Make `internal-link-present-evaluate` work with virtualNode rather than actualNode.

Closes issue dequelabs#2466

* test commit 1

* test commit 2

* test commit 3

* Revert "Merge branch 'dan-test-branch-1' into develop"

This reverts commit 428e015, reversing
changes made to 9f996bc.

* Revert "test commit 1"

This reverts commit 9f996bc.

* fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"

Closes issue dequelabs#2934

* Revert "fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive""

This reverts commit 30f0e01.

* refactor(check): split no-focusable-content rule into three.

That rule is now:
no-focusable-content-for-aria-text,
no-focusable-content-for-nested-interactive, and
no-focusable-content-for-frame

These three are all copy-and-pastes of each other, so far.

* fix(rule): add custom message for nested-interactive.

aria-hidden and negative tabindex will trigger messageKey.

* style(rule): fix lint errors

Errors were in parent commit.

* fix(no-focusable-content-for-frame): fix locale files

Was broken by recent rename of this check.

* refactor(check): undo recent check rename

Rename check "no-focusable-content-for-frame" back to "frame-focusable-content".

* refactor(check): undo recent split of checks

Recombine checks "no-focusable-content-for-aria-text" and "no-focusable-content-for-nested-interactive" back into "no-focusable-content".

* refactor(check): rename local variable

* fix(rule): make no-focusable-content not consult aria-hidden

no-focusable content now consults only tabindex (for the 'not a reliable way of hiding interactive elements' messageKey check)

* fix(checks/keyboard): make no-focusable-content use messageKey the right way

* refactor(check): misc. renaming and refactoring

* Updating description / messageKey text as per dequelabs#3163 (comment)

* add unit test for frame-focusable-content check

* update the no-focusable-content unit tests to add a test to capture negative tabindex

* update the nested-interactive integration test to add a failure for elements with negative tabindex values

* fix(no-focusable-content-for-frame): fix locale files

Was broken by recent rename of this check.

* Update lib/rules/nested-interactive.json

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* Update lib/checks/keyboard/no-focusable-content.json

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* fixing botched merge

* update rule-descriptions.md

* fix locale files

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

…3259)

…asssistive technologies (dequelabs#3262)

…ors (dequelabs#3215)

* fix(get-selector): do not URL encode or token escape attribute selectors

* escape

* more escape

* tests

* chore: Test against ARIA practices

* test: run APG#main nightly

* chore: sort out linting

* chore: bump CI image

* chore: Ready for review

* chore: tweaks

* chore: remove express

* chore: undo unintended change

* Apply suggestions from code review

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

…n a img element with a supported role (dequelabs#3224)

* ci: use lts-browsers for nightly tests

* browser tools

* steps?

* revert

* correctly nightly browsers

* test nightly build

* try again

* once more

* ci

* ci

* no deps

* fix

* fix

* :P

* final?

* final_final.psd

…equelabs#3261)

* fix(nested-interactive): add focusable descendants as related nodes

* fix tests

* fix

…s `null` (dequelabs#3249)

* Avoid crashes if postMessage data is `null`

axe-core crashes if another process sends a `window.postMessage` with
data equals to `null`.

In the previous version, because `null` has a type of `'object'`, it
crashed when trying to access the `channelId` on `null`.

* add test

Co-authored-by: Steven Lambert <steven.lambert@deque.com>

…ay (dequelabs#3279)

…equelabs#3278)

…equelabs#3275)

* fix(allowed-role): area without href can have a button or link role

* chore: remove failing test

…s#3273)

* feat(options): make axe.ping configurable with pingWaitTime

* chore: add to type definition

…s#3280)

* feat(dpub): upgrade to DPUB 1.1 and report deprecated roles

* Apply suggestions from code review

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* Handle fallback roles

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

…dequelabs-develop-2