Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White line between image #169

Closed
ghost opened this issue Jan 9, 2018 · 2 comments
Closed

White line between image #169

ghost opened this issue Jan 9, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Jan 9, 2018

Hi,

I'm converting html to pdf, which is working fine, but there are some vertical white lines appearing between images. Please see pdf and html attached.
Can you let me know how to fix that or is it a bug in the lib?

reviews.zip

@rototor
Copy link
Contributor

rototor commented Jan 15, 2018

I don't really know what you exactly mean with "white lines". A screenshot with a arrow to point out your problem would help.

But at least your tables do not page break correctly.

You should set

	-fs-table-paginate: paginate;

on the table and put

	display: table-header-group;

on the first row (i.e. the header row). And as you may guess from this info: Convert all your div rows to table rows and use a table per Review. If you want a clean and nice output here with correct page breaks you must use a table...

You can look at this sample how to do tables with repeated headers.

@danfickle
Copy link
Owner

I can no longer see white lines on the provided PDF in Chrome or Acrobat, so closing as I think this was a viewer issue.

danfickle added a commit that referenced this issue Sep 12, 2021
…ells

with a background color. I think this was a viewer issue. This commit contains proof PDF.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants