Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine lines appearing between table cells #291

Closed
ralleman opened this issue Nov 9, 2018 · 2 comments
Closed

Fine lines appearing between table cells #291

ralleman opened this issue Nov 9, 2018 · 2 comments

Comments

@ralleman
Copy link

ralleman commented Nov 9, 2018

Even with borders completely collapsed, there is still a fine line between the cells of tables when there is some background-color on the td, but not the tr or table. These lines are always the same width no matter how much I zoom the PDF. Setting the border-color to the same as the td background-color doesn't eliminate it.
fine-lines

@ralleman
Copy link
Author

ralleman commented Nov 9, 2018

fine-lines2

danfickle added a commit that referenced this issue Nov 11, 2018
@danfickle
Copy link
Owner

Hi @ralleman,

Thanks for the visual mock up highlighting the problem.

I've added a test that confirms this issue (and increases the chance that it will be fixed). I had a look in the generated PDF and on first inspection it looks correct (below). I suspect that the cause might be that PDF paths are not inclusive, but I'll have to look in the spec to confirm (and figure out what this means in the context of floating point units).

42 799.875 m
42 783.375 l
118.5 783.375 l
118.5 799.875 l
h
f
118.5 799.875 m
118.5 783.375 l
195 783.375 l
195 799.875 l
h
f
195 799.875 m
195 783.375 l
271.5 783.375 l
271.5 799.875 l
h
f
42 783.375 m
42 766.875 l
118.5 766.875 l
118.5 783.375 l
h
f
118.5 783.375 m
118.5 766.875 l
195 766.875 l
195 783.375 l
h
f
195 783.375 m
195 766.875 l
271.5 766.875 l
271.5 783.375 l
h
f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants