Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table borders are partly transparent #303

Closed
ralleman opened this issue Dec 6, 2018 · 3 comments
Closed

Table borders are partly transparent #303

ralleman opened this issue Dec 6, 2018 · 3 comments

Comments

@ralleman
Copy link

ralleman commented Dec 6, 2018

I have two neighbouring table cells with the border set to 4px between them. Irrespective of whether I set the border on the left cell or the right cell, or on both cells, half the border width becomes transparent.

In the example below, I applied the border to both cells and you can see that there are two transparent "halves" of the border.

image

Another, perhaps related issue I'm finding, but I can work around it, is that the vertical borders of table cells don't seem to have the same size as horizontal ones using the same border-width (they're visually wider than the horizontal ones). On divs, this isn't the case. horizontal and vertical borders on divs seem visually equal.

@danfickle
Copy link
Owner

Hi @ralleman,

Have you used border-collapse: collapse on the table? Also, you might run into #291 and #169.

@ralleman
Copy link
Author

Hi @danfickle,

Here are the styles on the table element:

image

And the left cell:

image

And the right cell:

image

Perhaps it's related to #291, but it's a different symptom though.

danfickle added a commit that referenced this issue Dec 24, 2018
…d table borders.

We were using a generic border bounds function to determine the clipping area for background painting. This did not take into account collapsed borders. We now use the collapsed border bounds, when available.

Includes tests for collapsed and separated table cell borders.
@danfickle
Copy link
Owner

Hi @ralleman,

Thanks for the extra information. I was able to reproduce the problem and push a fix. It turns out the problem wasn't the borders themselves, but the background coverage when using collapsed borders.

It is now using the correct background coverage, so I'll close this issue. Thank you for reporting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants