merging head fork #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a `lambda_function` module, which supports both EC2 classic and VPC. The problem I have, however, is that there is no way to specify a null configuration for `vpc_config`. This pull request changes the behavior so that the following Terraform configuration is //ignored//, instead of failing with an error (the current behavior):
```
resource "aws_lambda_function" "test" {
# ...
vpc_config {
security_group_ids = []
subnet_ids = []
}
}
```
See also #1187 and #1190.
* Updated via `govendor fetch github.com/aws/aws-sdk-go/...@v1.15.26`
Preparation for converting to Go modules. * Updated via: `govendor fetch github.com/hashicorp/go-uuid/...@v1.0.0`
Preparation for migrating to Go modules. Notable change: `net.Dailer` has `DualStack` enabled. Documentation: https://golang.org/pkg/net/#Dialer ``` // DualStack enables RFC 6555-compliant "Happy Eyeballs" // dialing when the network is "tcp" and the host in the // address parameter resolves to both IPv4 and IPv6 addresses. // This allows a client to tolerate networks where one address // family is silently broken. DualStack bool ``` * Updated via `govendor fetch github.com/hashicorp/go-cleanhttp/...@v0.5.0`
vendor: aws/aws-sdk-go@v1.15.26
Add example of credit specification block syntax
Add unit tests for validate funcs in neptune_event_subscription
Its no longer upcoming. :) Remove the existing event page from the provider as well since it now redirects to its new home: https://www.terraform.io/docs/extend/community/events/2018/summer-gardening.html
Added ForceNew for aws_redshift_cluster on availability_zone change
Add working URL for ICMP types and codes
vendor: hashicorp/go-cleanhttp@v0.5.0
Specify to use security group id in aws instance.
In preparation for Go modules. No-op change. 👍 * Updated via: `govendor fetch github.com/mitchellh/go-wordwrap/...@v1.0.0`
Reference: #5773 * Updated via: `govendor fetch github.com/mitchellh/hashstructure/...@v1.0.0` ``` $ make test TEST=./aws ==> Checking that code complies with gofmt requirements... go test ./aws -timeout=30s -parallel=4 ok github.com/terraform-providers/terraform-provider-aws/aws 2.537s ```
Reference: #5773 * Updated via: `govendor fetch github.com/jen20/awspolicyequivalence/...@v1.0.0` ``` $ make test TEST=./aws ==> Checking that code complies with gofmt requirements... go test ./aws -timeout=30s -parallel=4 ok github.com/terraform-providers/terraform-provider-aws/aws 2.451s ``` ``` --- PASS: TestAccAWSKmsKey_policy (39.10s) --- PASS: TestAccAWSS3BucketPolicy_basic (33.32s) --- PASS: TestAccAWSS3BucketPolicy_policyUpdate (46.38s) --- PASS: TestAccAwsSecretsManagerSecret_policy (12.56s) --- PASS: TestAccAWSSNSTopic_policy (9.78s) --- PASS: TestAccAWSSQSQueuePolicy_basic (15.60s) --- PASS: TestAccAWSSQSQueuePolicy_import (14.27s) --- PASS: TestAccAWSSQSQueue_policy (16.14s) ```
Reference: #5773 * Updated via `govendor fetch github.com/hashicorp/logutils/...@v1.0.0`
Reference: #5773 * Updated via: `govendor fetch github.com/hashicorp/go-safetemp/...@v1.0.0`
Reference: #5773 * Updated via: `govendor fetch github.com/mitchellh/go-homedir/...@v1.0.0`
…v1.0.0 Reference: #5773 * Updated via: ```govendor fetch github.com/mitchellh/copystructure/...@v1.0.0 govendor fetch github.com/mitchellh/reflectwalk/...@v1.0.0 ```
Reference: #5773 * Updated via: `govendor fetch github.com/apparentlymart/go-cidr/...@v1.0.0` ``` $ make test TEST=./aws ==> Checking that code complies with gofmt requirements... go test ./aws -timeout=30s -parallel=4 ok github.com/terraform-providers/terraform-provider-aws/aws 2.503s ```
Reference: #5773 * Updated via: `govendor fetch github.com/apparentlymart/go-textseg/...@v1.0.0`
…temp-v1.0.0 vendor: Pin hashicorp/go-safetemp@v1.0.0
…dir-v1.0.0 vendor: Pin mitchellh/go-homedir@v1.0.0
…ucture-v1.0.0 vendor: Pin mitchellh/copystructure@v1.0.0 and mitchellh/reflectwalk@v1.0.0
…-cidr-v1.0.0 vendor: apparentlymart/go-cidr@v1.0.0
…-textseg-v1.0.0 vendor: Pin apparentlymart/go-textseg@v1.0.0
….0.0 vendor: armon/go-radix@v1.0.0
…-v0.1.0 vendor: Pin bgentry/speakeasy@v0.1.0
…ierror-v1.0.0 vendor: Pin hashicorp/errwrap@v1.0.0 and hashicorp/go-multierror@v1.0.0
…0.0.4 vendor: mattn/go-isatty@v0.0.4
vendor: Pin ulikunitz/xz@v0.5.4
…-v1.2.1 vendor: Pin agext/levenshtein@v1.2.1
…kup logic Reinstates provider behavior previous to version 1.31.0 which silently allowed AWS account ID lookup failures during initialization. Since missing the AWS account ID in the provider has implications for quite a few data sources and resources, we will return the error in the next major version of the provider. * Replace error from provider AWS account ID lookup with WARN log message * Add information about change in behavior to Version 2 Upgrade Guide
…uesting_account_id docs/provider: Update skip_requesting_account_id affected resources
…uesting_account_id-error provider: WARN log instead of returning error with AWS account ID lookup logic
…orm-provider-aws into b-aws_lambda_function-empty-vpc-handling
Includes preventing panics as started by #5792 * Adds acceptance test (`TestAccAWSLambdaFunction_VPCRemoval`) to cover `vpc_config` removal * Prevents panic when removing `vpc_config` * Properly handles vpc_config removal to prevent perpetual difference Previously: ``` --- FAIL: TestAccAWSLambdaFunction_VPCRemoval (42.52s) testing.go:527: Step 1 error: Check failed: Check 2/2 error: aws_lambda_function.lambda_function_test: Attribute 'vpc_config.#' expected "0", got "1" ``` Now: ``` --- PASS: TestAccAWSLambdaFunction_VPCRemoval (51.23s) ```
…on-empty-vpc-handling resource/aws_lambda_function: Properly handle `vpc_config` removal
…ence/terraform-provider-aws into joshuaspence-lambda-empty_vpc_config
r/aws_eks_cluster, d/aws_eks_cluster: Add support for EKS Platform Version
… DiffSuppressFunc and refactor for early returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Changes proposed in this pull request:
Output from acceptance testing: