secretstores: support more format of azure key vault #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Long Dai <long0dai@foxmail.com>
Member
Author
|
ping @pkedy |
Contributor
|
Code change looks good. @daixiang0 per the PR checklist, can you also file an issue for dapr/docs and update the https://docs.dapr.io/reference/components-reference/supported-secret-stores/azure-keyvault/ to describe the updated behavior for |
Member
Author
|
@CodeMonkeyLeet done. |
6 tasks
Member
Author
|
@pkedy hi, is there anything I can do to make it merged? |
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #944 +/- ##
==========================================
- Coverage 34.44% 34.42% -0.02%
==========================================
Files 132 132
Lines 10551 10555 +4
==========================================
Hits 3634 3634
- Misses 6539 6543 +4
Partials 378 378
Continue to review full report at Codecov.
|
Member
|
Thanks for your contribution @daixiang0 |
Taction
added a commit
to Taction/components-contrib
that referenced
this pull request
Jul 15, 2021
* master: (23 commits) Adds support for TTL in Redis State Store (dapr#990) Adds support for TTL in Memcached State Store (PR Fixup) (dapr#1011) Adds support for TTL in Cassandra State Store (dapr#996) Return blob metadata and add list operation (dapr#999) Added new output binding for Cosmos Graph DB - Gremlin (dapr#885) Adds support for TTL in CosmosDB State Store (dapr#991) Delete unused code and update test (dapr#924) Return SystemProperties on events from EventHubs bindings and pubsub (dapr#1009) Implement E2E tests for zeebe (dapr#973) rebase (dapr#982) Update CODEOWNERS (dapr#987) ci: add test skip case (dapr#922) fix: Mysql should support more data types. dapr#923 (dapr#926) fix: Dapr runtime panic when handle Pub/Sub (dapr#3281) (dapr#967) switch to golang-jwt (dapr#993) unmarshal getBlobRetryCount as int (dapr#919) secretstores: support more format of azure key vault (dapr#944) Optimize vault secret component error output (dapr#909) Convert AZURE_KEYVAULT in conformance.yml a GitHub secret (dapr#1002) Use AzureKeyVaultName param for Azure Keyvault conformance test (dapr#975) ... # Conflicts: # secretstores/hashicorp/vault/vault.go
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Long Dai long0dai@foxmail.com
Description
Check whether the URI match DNS suffix, if not, use Azure Cloud DNS suffix by default.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #918
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: