Implement E2E tests for the Zeebe binding #973
Conversation
|
@pkedy Would be great if you could give some early feedback if this goes in the right direction. |
|
@akkie You've got some linter errors breaking the build but this look like its structured well. You've got a README and docker compose for running it which is great. |
|
@pkedy Do you have a suggestion how I can resolve the issue regarding the global variables. I would like to share them between the tests. |
|
I have created a getter for the environment variables to fix the global lint issue. I have also created a new entry in the makefile to run the tests from CI. I have not created a new workflow for E2E tests, because I'm not sure if each test should run separate or if it makes sense to create a shell script that runs all the E2E tests. From my perspective the PR is finished and can be reviewed. |
|
@akkie please resolve conflicts and we can merge. |
|
@yaron2 Done |
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 30.59% 34.32% +3.72%
==========================================
Files 85 132 +47
Lines 7148 10550 +3402
==========================================
+ Hits 2187 3621 +1434
- Misses 4724 6552 +1828
- Partials 237 377 +140
Continue to review full report at Codecov.
|
* master: (23 commits) Adds support for TTL in Redis State Store (dapr#990) Adds support for TTL in Memcached State Store (PR Fixup) (dapr#1011) Adds support for TTL in Cassandra State Store (dapr#996) Return blob metadata and add list operation (dapr#999) Added new output binding for Cosmos Graph DB - Gremlin (dapr#885) Adds support for TTL in CosmosDB State Store (dapr#991) Delete unused code and update test (dapr#924) Return SystemProperties on events from EventHubs bindings and pubsub (dapr#1009) Implement E2E tests for zeebe (dapr#973) rebase (dapr#982) Update CODEOWNERS (dapr#987) ci: add test skip case (dapr#922) fix: Mysql should support more data types. dapr#923 (dapr#926) fix: Dapr runtime panic when handle Pub/Sub (dapr#3281) (dapr#967) switch to golang-jwt (dapr#993) unmarshal getBlobRetryCount as int (dapr#919) secretstores: support more format of azure key vault (dapr#944) Optimize vault secret component error output (dapr#909) Convert AZURE_KEYVAULT in conformance.yml a GitHub secret (dapr#1002) Use AzureKeyVaultName param for Azure Keyvault conformance test (dapr#975) ... # Conflicts: # secretstores/hashicorp/vault/vault.go
3 participants
Description
This PR implements E2E tests for the Zeebe binding.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: