Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Open Sans Bold web font in dartlang.org pages #21

Closed
DartBot opened this issue Oct 10, 2011 · 1 comment
Closed

Include Open Sans Bold web font in dartlang.org pages #21

DartBot opened this issue Oct 10, 2011 · 1 comment

Comments

@DartBot
Copy link

DartBot commented Oct 10, 2011

This issue was originally filed by sander.dijkhu...@gmail.com

The pages on dartlang.org use this tag to load Open Sans:

<link href='http://fonts.googleapis.com/css?family=Open+Sans' rel='stylesheet' type='text/css'>

This doesn't load the boldface file, while some parts like .intro > dl > dt are set in boldface. Currently this means that the regular font is made bold programmatically at these places, which looks very bad.

Instead, please use this tag:

<link href='http://fonts.googleapis.com/css?family=Open+Sans:400,700' rel='stylesheet' type='text/css'>
@DartBot
Copy link
Author

DartBot commented Oct 11, 2011

This comment was originally written by drfibonacci@google.com

Done, will show up in next push

Set owner to drfibonacci@google.com.
Added Component-Docs, Fixed labels.

@kodandersson kodandersson mentioned this issue Jun 23, 2015
Closed
@kodandersson kodandersson mentioned this issue Aug 28, 2015
Closed
@danrubel danrubel mentioned this issue Sep 2, 2015
Closed
@iposva-google iposva-google mentioned this issue Sep 21, 2015
Closed
@scheglov scheglov mentioned this issue Oct 19, 2015
Closed
@danrubel danrubel mentioned this issue Oct 23, 2015
Closed
@whesse whesse mentioned this issue Nov 4, 2015
Closed
@bwilkerson bwilkerson mentioned this issue Nov 9, 2015
Closed
@zoechi zoechi mentioned this issue Nov 21, 2015
Closed
This was referenced Dec 2, 2015
Closed
Closed
@fsc8000 fsc8000 mentioned this issue Dec 9, 2015
Closed
@bwilkerson bwilkerson mentioned this issue Jan 3, 2016
Closed
@zoechi zoechi mentioned this issue Jan 7, 2016
Closed
@bwilkerson bwilkerson mentioned this issue Jan 19, 2016
Closed
This was referenced Feb 2, 2016
Closed
Closed
@kzhdev kzhdev mentioned this issue Feb 14, 2016
Closed
@bwilkerson bwilkerson mentioned this issue Feb 19, 2016
Closed
This was referenced Feb 29, 2016
Closed
Closed
@pemdas pemdas mentioned this issue Mar 1, 2016
Closed
@whesse whesse mentioned this issue Mar 3, 2016
Closed
@skybrian skybrian mentioned this issue Mar 6, 2016
Closed
@zoechi zoechi mentioned this issue Mar 10, 2016
Closed
@FarhanAli-98 FarhanAli-98 mentioned this issue Jun 8, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Jul 21, 2023
@jiahaog
[dart2wasm] Fix location RangeError when using part
11d0f06 
Here's a minimal repro that this CL fixes:

`ui.dart`

```dart
library dart.ui;

import 'dart:ffi';

part 'foo.dart';
```

`foo.dart`

```dart
part of dart.ui;

@Native<Void Function()>(symbol: 'foo_func', isLeaf: true)
external void foo_func();
```

When compiling with `compile_platform.dart` with `--target=dart2wasm`, the following error appears:


```
Unhandled exception:
Verification error: Target=wasm, VerificationStage.afterModularTransformations: Invalid location with target 'wasm' on FunctionNode() (FunctionNode): RangeError (offset): Invalid value: Not in inclusive range 0..56: 91
Context: 'foo_func_$import'.
Node: 'FunctionNode()'.
#0      VerificationErrorListener.reportError (package:kernel/verifier.dart:81:5)
#1      VerifyingVisitor.problem (package:kernel/verifier.dart:222:14)
#2      VerifyingVisitor._getLocation (package:kernel/verifier.dart:1361:7)
#3      VerifyingVisitor._hasLocation (package:kernel/verifier.dart:1370:26)
#4      VerifyingVisitor.getSameLibraryLastSeenTreeNode (package:kernel/verifier.dart:1342:28)
#5      VerifyingVisitor.localContext (package:kernel/verifier.dart:1382:24)
#6      VerifyingVisitor.defaultDartType (package:kernel/verifier.dart:1491:41)
#7      Visitor.visitVoidType (package:kernel/visitor.dart:1309:37)
#8      VoidType.accept (package:kernel/ast.dart:11190:42)
#9      FunctionNode.visitChildren (package:kernel/ast.dart:3919:16)
#10     VerifyingVisitor.visitChildren (package:kernel/verifier.dart:259:10)
#11     VerifyingVisitor.visitWithLocalScope (package:kernel/verifier.dart:266:5)
#12     VerifyingVisitor.visitFunctionNode (package:kernel/verifier.dart:721:5)
#13     FunctionNode.accept (package:kernel/ast.dart:3908:38)
#14     VerifyingVisitor.visitProcedure (package:kernel/verifier.dart:620:19)
#15     Procedure.accept (package:kernel/ast.dart:3311:40)
#16     visitList (package:kernel/ast.dart:14488:14)
#17     Library.visitChildren (package:kernel/ast.dart:591:5)
#18     VerifyingVisitor.visitChildren (package:kernel/verifier.dart:259:10)
#19     VerifyingVisitor.defaultTreeNode (package:kernel/verifier.dart:196:5)
#20     TreeVisitor.visitLibrary (package:kernel/visitor.dart:503:35)
#21     VerifyingVisitor.visitLibrary (package:kernel/verifier.dart:367:11)
#22     Library.accept (package:kernel/ast.dart:577:38)
#23     visitList (package:kernel/ast.dart:14488:14)
#24     Component.visitChildren (package:kernel/ast.dart:14320:5)
#25     VerifyingVisitor.visitChildren (package:kernel/verifier.dart:259:10)
#26     VerifyingVisitor.visitComponent (package:kernel/verifier.dart:342:7)
#27     Component.accept (package:kernel/ast.dart:14313:38)
#28     VerifyingVisitor.check (package:kernel/verifier.dart:171:15)
#29     verifyComponent (package:kernel/verifier.dart:69:20)
...
```

The issue seems to be that after doing this native transformation, the node's `fileUri` references the enclosing library (`ui.dart` above), but the `node.location` references the actual source file (`foo.dart` above) indirectly through `node.fileOffset`.

This ends up being an issue when compiling the platform dill in Google3,   but I didn't look into why `flutter build web --wasm` isn't broken.

Internal bug: b/292172146

Change-Id: I2b8d7d215b2c36354860257ce651d50168e9523d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315360
Reviewed-by: Ömer Ağacan <omersa@google.com>
Commit-Queue: Jia Hao Goh <jiahaog@google.com>
@heshesh2010 heshesh2010 mentioned this issue Aug 12, 2023
Closed
@ebraminio ebraminio mentioned this issue Aug 18, 2023
Closed
@shubham-jain2 shubham-jain2 mentioned this issue Aug 24, 2023
Closed
@llfbandit llfbandit mentioned this issue Sep 10, 2023
Closed
@Pisey-Nguon Pisey-Nguon mentioned this issue Sep 11, 2023
Closed
@Raj-impetrosys Raj-impetrosys mentioned this issue Sep 15, 2023
Closed
@bernardolansing bernardolansing mentioned this issue Sep 27, 2023
Closed
@manandhar-aarya manandhar-aarya mentioned this issue Oct 9, 2023
Closed
@johnpryan johnpryan mentioned this issue Oct 10, 2023
Closed
@mboyanna mboyanna mentioned this issue Dec 7, 2023
Closed
@cosminbodnariuc cosminbodnariuc mentioned this issue Dec 7, 2023
Closed
@mnts mnts mentioned this issue Feb 6, 2024
Open
@JgomesAT JgomesAT mentioned this issue Feb 28, 2024
Closed
@adityasaxen adityasaxen mentioned this issue Mar 14, 2024
Closed
@upasana-khatiwada upasana-khatiwada mentioned this issue Mar 16, 2024
Closed
@butterbrain butterbrain mentioned this issue Apr 4, 2024
Closed
@abhisiroha abhisiroha mentioned this issue Apr 24, 2024
Closed
@eernstg eernstg mentioned this issue Jul 1, 2024
Open
@Lootwig Lootwig mentioned this issue Jul 18, 2024
Open
@the-mrinal the-mrinal mentioned this issue Jul 31, 2024
Open
@ailabs-software ailabs-software mentioned this issue Aug 6, 2024
Closed
@thermoworker thermoworker mentioned this issue Aug 12, 2024
Open
@theaquaflower theaquaflower mentioned this issue Aug 15, 2024
Closed
@SwederSchellens SwederSchellens mentioned this issue Sep 24, 2024
Closed
@mjablecnik mjablecnik mentioned this issue Sep 27, 2024
Open
@ChaserVasya ChaserVasya mentioned this issue Oct 20, 2024
Open
Open
antonbashir added a commit to antonbashir/dart that referenced this issue Nov 21, 2024
@antonbashir
Merge pull request 'fibers' (dart-lang#21) from fibers into main
6735573 
Reviewed-on: http://git.local/dependencies/dart/pulls/21
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DartBot